Skip to content

fix(evaluators): satisfy budget package-local checks#189

Closed
lan17 wants to merge 3 commits intofeature/contrib-normalizefrom
feature/contrib-budget-check-fixes
Closed

fix(evaluators): satisfy budget package-local checks#189
lan17 wants to merge 3 commits intofeature/contrib-normalizefrom
feature/contrib-budget-check-fixes

Conversation

@lan17
Copy link
Copy Markdown
Contributor

@lan17 lan17 commented Apr 21, 2026

Summary

  • remove the quoted self-type annotation in the budget config validator so the package-local Ruff pass is clean
  • tighten token extraction typing in the budget evaluator so parsed token counts are guaranteed to be integers
  • narrow model_path before calling the path extractor so package-local mypy passes cleanly

Why

PR 188 left the contrib budget package with pre-existing local check failures in its source. This change is intentionally narrow and keeps the existing package normalization work from feature/contrib-normalize intact while making make -C evaluators/contrib/budget check pass.

Validation

  • make -C evaluators/contrib/budget check

Design Context

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lan17 lan17 changed the title fix(budget): satisfy package-local checks fix(evaluators): satisfy budget package-local checks Apr 21, 2026
@lan17 lan17 force-pushed the feature/contrib-normalize branch from e686cc7 to 69cdab5 Compare April 21, 2026 04:49
@lan17 lan17 force-pushed the feature/contrib-budget-check-fixes branch from 61b24bf to ec7ec58 Compare April 21, 2026 04:49
@lan17
Copy link
Copy Markdown
Contributor Author

lan17 commented Apr 21, 2026

Superseded by #193, which rolls up this reviewed stack into one PR while preserving the logical commit boundaries for review.

@lan17 lan17 closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant