fix(evaluators): satisfy budget package-local checks#189
Closed
lan17 wants to merge 3 commits intofeature/contrib-normalizefrom
Closed
fix(evaluators): satisfy budget package-local checks#189lan17 wants to merge 3 commits intofeature/contrib-normalizefrom
lan17 wants to merge 3 commits intofeature/contrib-normalizefrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
e686cc7 to
69cdab5
Compare
61b24bf to
ec7ec58
Compare
Contributor
Author
|
Superseded by #193, which rolls up this reviewed stack into one PR while preserving the logical commit boundaries for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_pathbefore calling the path extractor so package-local mypy passes cleanlyWhy
PR 188 left the contrib
budgetpackage with pre-existing local check failures in its source. This change is intentionally narrow and keeps the existing package normalization work fromfeature/contrib-normalizeintact while makingmake -C evaluators/contrib/budget checkpass.Validation
make -C evaluators/contrib/budget checkDesign Context