Skip to content

ci(infra): make root checks contrib-aware#191

Closed
lan17 wants to merge 3 commits intofeature/contrib-release-automationfrom
feature/contrib-root-check
Closed

ci(infra): make root checks contrib-aware#191
lan17 wants to merge 3 commits intofeature/contrib-release-automationfrom
feature/contrib-root-check

Conversation

@lan17
Copy link
Copy Markdown
Contributor

@lan17 lan17 commented Apr 21, 2026

Summary

  • remove Galileo-specific contrib wiring from the root Makefile and replace it with discovery-driven contrib targets
  • make root test, lint, typecheck, and build cover every discovered contrib package via python3 scripts/contrib_packages.py names
  • add a blocking contrib packaging drift gate to CI and run make check as the single blocking Python path

Why

Phase 3 of the contrib packaging rollout makes root correctness include every real contrib package and keeps CI aligned with the developer entrypoint instead of letting separate CI steps drift.

Validation

  • python3 scripts/contrib_packages.py names
  • python3 scripts/contrib_packages.py verify
  • make test-extras (fails on an existing stacked Galileo package-local tooling issue: plain uv run pytest cannot find pytest)
  • make lint (fails on the same existing Galileo package-local tooling issue: plain uv run ruff cannot find ruff)
  • make typecheck (fails on the same existing Galileo package-local tooling issue: plain uv run mypy cannot find mypy)
  • make check (started after make sync; server tests errored under local DB assumptions before the contrib phase, so the run was terminated after confirming the environment-bound blocker)
  • make build

Stacked context

This branch currently includes stacked foundation commits from the local integration of feature/contrib-discovery and feature/contrib-budget-check-fixes. A follow-on rebase or restack against the final landed base branches will likely be needed before merge.

Design Context

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lan17 lan17 changed the title ci: make root checks contrib-aware ci(contrib): make root checks contrib-aware Apr 21, 2026
@lan17 lan17 changed the title ci(contrib): make root checks contrib-aware ci(infra): make root checks contrib-aware Apr 21, 2026
@lan17 lan17 force-pushed the feature/contrib-root-check branch from d7e9af5 to b86e76d Compare April 21, 2026 04:49
@lan17 lan17 changed the base branch from main to feature/contrib-release-automation April 21, 2026 04:49
@lan17
Copy link
Copy Markdown
Contributor Author

lan17 commented Apr 21, 2026

Superseded by #193, which rolls up this reviewed stack into one PR while preserving the logical commit boundaries for review.

@lan17 lan17 closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant