Skip to content

build(evaluators): normalize package-local Makefile targets#192

Closed
lan17 wants to merge 1 commit intofeature/contrib-budget-check-fixesfrom
feature/contrib-makefile-contract
Closed

build(evaluators): normalize package-local Makefile targets#192
lan17 wants to merge 1 commit intofeature/contrib-budget-check-fixesfrom
feature/contrib-makefile-contract

Conversation

@lan17
Copy link
Copy Markdown
Contributor

@lan17 lan17 commented Apr 21, 2026

What changed

  • added the missing check target to the Galileo and Cisco contrib package Makefiles
  • updated both packages to run pytest, ruff, and mypy with uv run --package <contrib-package> so the local contrib project stays selected outside the root workspace
  • kept the package-local contract narrow and aligned with the shared target surface used by root automation

Why

The contrib packages live outside the root uv workspace, so package-local uv run behavior can drift from the root-driven make -C <package> flow. Galileo was failing before the tool even reached the package code because the command resolution did not reliably run in the local project context.

Impact

Root automation can rely on both contrib packages exposing test, lint, lint-fix, typecheck, check, and build without package-specific command drift blocking the contrib contract cleanup.

Validation

  • make -C evaluators/contrib/galileo lint-fix
  • make -C evaluators/contrib/galileo check
  • make -C evaluators/contrib/galileo build
  • make -C evaluators/contrib/cisco lint-fix
  • make -C evaluators/contrib/cisco check
  • make -C evaluators/contrib/cisco build

Design Context

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lan17 lan17 changed the title [codex] Normalize contrib Makefile targets build(contrib): normalize package-local Makefile targets Apr 21, 2026
@lan17 lan17 changed the title build(contrib): normalize package-local Makefile targets build(evaluators): normalize package-local Makefile targets Apr 21, 2026
@lan17 lan17 force-pushed the feature/contrib-makefile-contract branch from 57503af to 8d2410d Compare April 21, 2026 04:49
@lan17 lan17 changed the base branch from main to feature/contrib-budget-check-fixes April 21, 2026 04:49
@lan17
Copy link
Copy Markdown
Contributor Author

lan17 commented Apr 21, 2026

Superseded by #193, which rolls up this reviewed stack into one PR while preserving the logical commit boundaries for review.

@lan17 lan17 closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant