Skip to content

Commit 0018be2

Browse files
committed
Apply feedback
1 parent 69f6a83 commit 0018be2

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

examples/kubernetes/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ helm upgrade --install otel-collector open-telemetry/opentelemetry-collector \
6868
--set config.service.pipelines.logs.exporters[0]=otlp
6969
```
7070

71-
> **Note:** If you deployed agentevals in a namespace other than `default`, update the `endpoint` value accordingly: `http://agentevals.<namespace>.svc.cluster.local:4318`.
71+
> **Note:** If you deployed agentevals in a namespace other than `default`, update the `endpoint` value accordingly: `http://agentevals.<namespace>.svc.cluster.local:4317`.
7272
7373
### 3. kagent
7474

@@ -98,6 +98,8 @@ helm upgrade --install kagent oci://ghcr.io/kagent-dev/kagent/helm/kagent \
9898

9999
This installs kagent with only the default Helm agent (`helm-agent`) and the K8s troubleshooter enabled, and points its OTel exporter at the Collector.
100100

101+
> **Note:** In case you are not using the OTel Collector, you can set the `otel.tracing.exporter.otlp.endpoint` to `agentevals.default.svc.cluster.local:4317`.
102+
101103
### Verify the deployment
102104

103105
```bash
@@ -252,4 +254,4 @@ helm uninstall kagent-crds -n kagent
252254
helm uninstall otel-collector -n kagent
253255
helm uninstall agentevals
254256
kubectl delete namespace kagent
255-
```
257+
```

src/agentevals/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ async def _run_servers(
580580

581581
_install_shared_exit_handler(
582582
*uvicorn_servers,
583-
otlp_grpc_server,
583+
grpc_server=otlp_grpc_server,
584584
)
585585

586586
try:

0 commit comments

Comments
 (0)