fix: support legacy gen_ai.prompt/completion attributes for Ollama traces#136
Open
mesutoezdil wants to merge 3 commits into
Open
fix: support legacy gen_ai.prompt/completion attributes for Ollama traces#136mesutoezdil wants to merge 3 commits into
mesutoezdil wants to merge 3 commits into
Conversation
mesutoezdil
force-pushed
the
fix/legacy-genai-attributes
branch
from
7368aaa to
369fe1d
Compare
1 task
mesutoezdil
force-pushed
the
fix/legacy-genai-attributes
branch
from
369fe1d to
0b82f18
Compare
mesutoezdil
force-pushed
the
fix/legacy-genai-attributes
branch
from
0b82f18 to
050c2d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88
Ollama's instrumentor emits flat indexed attributes instead of JSON arrays:
Added a fallback in extraction.py that reads these when the standard attributes are absent. Standard attributes still take priority. Five tests cover the new path.