Fix #289: resolve 11 pre-existing test failures on main#304
Open
ericleepi314 wants to merge 1 commit into
Open
Fix #289: resolve 11 pre-existing test failures on main#304ericleepi314 wants to merge 1 commit into
ericleepi314 wants to merge 1 commit into
Conversation
- providers: mocks predated the with_options timeout wrap; mock it as a pass-through and add dedicated _apply_client_timeout coverage - parity: scope TS property defaults to TS core tools (advisor/Workflow are Python-only and legitimately read-only/concurrency-safe) - mcp: validate with sys.executable, not bare "python" (absent on python3-only systems) - web_fetch: regex fallback now strips iframe/object/embed like the bs4 path does - bridge: tolerate the stale __pycache__ namespace package that survives branch switches; still fails if the real shim returns - pyproject: testpaths=["tests"] so bare pytest doesn't collect reference_projects/ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #289
Summary
Full
pytest testson main was red with 13 failures; 2 are tracked separately in #274. This fixes the other 11, each at its root cause:with_options(timeout=…, max_retries=…)(stalled-stream protection); test mocks predated itwith_optionsas pass-through + newTestApplyClientTimeout(3 tests) covering the wrap kwargs, env overrides, and the failure fallbackadvisor/Workfloware Python-only and legitimately read-only/concurrency-safets_tool_names.json)command="python"absent from PATH on python3-only systemssys.executable_NOISE_BLOCK_REmissediframe|object|embedwhich the bs4 path strips — real implementation bug, iframe content leaked into extracted textsrc/services/bridge/__pycache__in a checkout survives branch switches and imports as a namespace packagefind_spec; tolerateorigin is None(namespace pkg), still fail if a real shim (__init__.py) returnsAlso adds
testpaths = ["tests"]per the issue's suggestion so barepytestno longer aborts collection onreference_projects/.Test plan
__pycache__dirCLAWCODEX_LLM_*env vars🤖 Generated with Claude Code