style: gofmt -s simplifications

drops the goreportcard warnings, no behaviour change. mostly composite
literal type elisions and slice/range simplifications.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: brtkwr

cmd/zeltapp/cache_cmd.go

@@ -51,10 +51,10 @@ func cacheListCmd() *cobra.Command {
 					expiry = remaining.Round(time.Second).String()
 				}
 				rows = append(rows, map[string]any{
-					"path":          entry.Path,
-					"storedAt":      entry.StoredAt.Format(time.RFC3339),
-					"expiresIn":     expiry,
-					"size":          len(entry.Body),
+					"path":      entry.Path,
+					"storedAt":  entry.StoredAt.Format(time.RFC3339),
+					"expiresIn": expiry,
+					"size":      len(entry.Body),
 				})
 			}
 			if len(rows) == 0 {

cmd/zeltapp/client.go

@@ -94,10 +94,10 @@ func (s *fileStore) ClearSession() error {
 }
 
 // loadSession / saveSession / clearSession compat shims used by older command files.
-func loadSession() (*session, error)    { return defaultStore().LoadSession() }
-func saveSession(s *session) error      { return defaultStore().SaveSession(s) }
-func clearSession() error               { return defaultStore().ClearSession() }
-func sessionPath() string               { return defaultStore().sessionPath() }
+func loadSession() (*session, error) { return defaultStore().LoadSession() }
+func saveSession(s *session) error   { return defaultStore().SaveSession(s) }
+func clearSession() error            { return defaultStore().ClearSession() }
+func sessionPath() string            { return defaultStore().sessionPath() }
 
 type client struct {
 	http    *http.Client
@@ -112,11 +112,11 @@ type client struct {
 
 type clientOpt func(*client)
 
-func withBaseURL(u string) clientOpt        { return func(c *client) { c.baseURL = u } }
-func withHTTP(h *http.Client) clientOpt     { return func(c *client) { c.http = h } }
-func withStore(s store) clientOpt           { return func(c *client) { c.store = s } }
-func withNow(f func() time.Time) clientOpt  { return func(c *client) { c.now = f } }
-func withVerbose(v bool) clientOpt          { return func(c *client) { c.verbose = v } }
+func withBaseURL(u string) clientOpt       { return func(c *client) { c.baseURL = u } }
+func withHTTP(h *http.Client) clientOpt    { return func(c *client) { c.http = h } }
+func withStore(s store) clientOpt          { return func(c *client) { c.store = s } }
+func withNow(f func() time.Time) clientOpt { return func(c *client) { c.now = f } }
+func withVerbose(v bool) clientOpt         { return func(c *client) { c.verbose = v } }
 
 func newClient(opts ...clientOpt) (*client, error) {
 	jar, err := cookiejar.New(nil)

cmd/zeltapp/client_test.go

@@ -42,7 +42,9 @@ func TestClient_DoSendsJSONBody(t *testing.T) {
 	st.jsonRoute("POST", "/apiv2/test", 201, []byte(`{"ok":true}`))
 	c, _ := newAuthedTestClient(t, srv)
 
-	type req struct{ X int `json:"x"` }
+	type req struct {
+		X int `json:"x"`
+	}
 	if err := c.do("POST", "/apiv2/test", req{X: 42}, nil); err != nil {
 		t.Fatal(err)
 	}

cmd/zeltapp/leave.go

@@ -28,10 +28,10 @@ type balanceResp struct {
 }
 
 type bookResp struct {
-	Success            bool              `json:"success"`
-	Method             string            `json:"method"`
-	NoOfCreatedAbsences int              `json:"noOfCreatedAbsences"`
-	SkippedUsers       []json.RawMessage `json:"skippedUsers"`
+	Success             bool              `json:"success"`
+	Method              string            `json:"method"`
+	NoOfCreatedAbsences int               `json:"noOfCreatedAbsences"`
+	SkippedUsers        []json.RawMessage `json:"skippedUsers"`
 }
 
 func leaveCmd() *cobra.Command {
@@ -205,7 +205,7 @@ func addBookFlags(cmd *cobra.Command, policy *int, start, end, notes *string, mo
 func runDryRun(c *client, policy int, start, end, notes string, morning, afternoon, alsoBalance bool) error {
 	overlapReq := map[string]any{
 		"absenceStart": start, "absenceEnd": nilIfEmpty(end), "absenceId": nil,
-		"userIds": []int{c.session.UserID},
+		"userIds":     []int{c.session.UserID},
 		"morningOnly": morning, "afternoonOnly": afternoon,
 		"startHour": nil, "endHour": nil,
 	}

cmd/zeltapp/leave_test.go

@@ -162,7 +162,7 @@ func TestLeave_VerifyOverlapBodyShape(t *testing.T) {
 
 	overlapReq := map[string]any{
 		"absenceStart": "2030-06-01", "absenceEnd": nil, "absenceId": nil,
-		"userIds": []int{c.session.UserID},
+		"userIds":     []int{c.session.UserID},
 		"morningOnly": false, "afternoonOnly": false,
 		"startHour": nil, "endHour": nil,
 	}

cmd/zeltapp/main.go

@@ -25,10 +25,10 @@ var (
 
 func main() {
 	root := &cobra.Command{
-		Use:     "zeltapp",
-		Short:   "Unofficial CLI for the Zelt HR platform",
-		Long:    "zeltapp talks to https://go.zelt.app/apiv2/* using a cookie session.\nRun `zeltapp login` first.",
-		Version: version,
+		Use:           "zeltapp",
+		Short:         "Unofficial CLI for the Zelt HR platform",
+		Long:          "zeltapp talks to https://go.zelt.app/apiv2/* using a cookie session.\nRun `zeltapp login` first.",
+		Version:       version,
 		SilenceUsage:  true,
 		SilenceErrors: true, // we render errors ourselves below
 	}

cmd/zeltapp/people.go

@@ -246,11 +246,11 @@ func toPresentable(arr []peopleCacheEntry) []any {
 	out := make([]any, 0, len(arr))
 	for _, p := range arr {
 		row := map[string]any{
-			"userId":       p.UserID,
-			"name":         p.DisplayName,
-			"email":        p.EmailAddress,
-			"jobPosition":  p.JobPosition,
-			"department":   p.Department,
+			"userId":      p.UserID,
+			"name":        p.DisplayName,
+			"email":       p.EmailAddress,
+			"jobPosition": p.JobPosition,
+			"department":  p.Department,
 		}
 		if row["name"] == "" {
 			row["name"] = strings.TrimSpace(p.FirstName + " " + p.LastName)

cmd/zeltapp/testutil_test.go

@@ -101,15 +101,15 @@ var fixtureAuthMe = mustJSON(map[string]any{
 		"company": map[string]any{
 			"companyId": fakeCompanyID, "name": "Example Co", "slug": "example-co",
 		},
-		"mfaType":    "email",
-		"language":   "en",
-		"currency":   "GBP",
+		"mfaType":      "email",
+		"language":     "en",
+		"currency":     "GBP",
 		"contractType": "Payrolled",
 		"scopes2":      []map[string]string{{"scope": "user"}, {"scope": "absence"}},
 	},
-	"isSuperAdmin":     false,
+	"isSuperAdmin":      false,
 	"hasUnpaidInvoices": false,
-	"publicURL":        "https://go.zelt.app/files",
+	"publicURL":         "https://go.zelt.app/files",
 })
 
 var fixtureLoginStep1 = mustJSON(map[string]any{"mfaType": "email"})
@@ -123,9 +123,9 @@ var fixtureLoginStep2 = mustJSON(map[string]any{
 
 // fixtureAbsenceVerifyOverlap mirrors /apiv2/absences/verify-overlap.
 var fixtureAbsenceVerifyOverlap = mustJSON(map[string]any{
-	"isOverlapping":     false,
-	"absences":          []any{},
-	"events":            []any{},
+	"isOverlapping":      false,
+	"absences":           []any{},
+	"events":             []any{},
 	"preventOwnOverlaps": true,
 })
 
@@ -152,10 +152,10 @@ var fixtureRequestValueBalance = mustJSON(map[string]any{
 })
 
 var fixtureBookSuccess = mustJSON(map[string]any{
-	"success":            true,
-	"method":             "direct",
+	"success":             true,
+	"method":              "direct",
 	"noOfCreatedAbsences": 1,
-	"skippedUsers":       []any{},
+	"skippedUsers":        []any{},
 })
 
 var fixtureLeaveDays = mustJSON(map[string]any{
@@ -176,9 +176,9 @@ var fixtureAttendanceWidget = mustJSON(map[string]any{
 })
 
 var fixtureCalendar = mustJSON(map[string]any{
-	"users":   []any{},
-	"days":    []any{},
-	"totals":  map[string]int{"absences": 0, "events": 0},
+	"users":  []any{},
+	"days":   []any{},
+	"totals": map[string]int{"absences": 0, "events": 0},
 })
 
 var fixtureExpenses = mustJSON(map[string]any{
@@ -211,10 +211,10 @@ type recordedRequest struct {
 type routeHandler func(w http.ResponseWriter, r *http.Request, body []byte)
 
 type serverState struct {
-	mu         sync.Mutex
-	requests   []recordedRequest
-	routes     map[string]routeHandler // key: METHOD PATH (path without query)
-	notFound   routeHandler
+	mu       sync.Mutex
+	requests []recordedRequest
+	routes   map[string]routeHandler // key: METHOD PATH (path without query)
+	notFound routeHandler
 }
 
 func newServerState() *serverState {