pi-agenticoding/03: silence stale manual handoff cleanup

Author: grzegorznowak

CHANGELOG.md

@@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **Breaking:** handoff no longer auto-sends `Proceed.` after compaction and no longer supports configurable auto-resume. The superseded `handoff.resumeBehavior` (`"wait"`/`"proceed"`) setting is ignored.
 - Added `handoff.automaticEnabled` raw settings support with JSON boolean values. Missing settings default to automatic handoff enabled; `false` removes the agent-facing handoff tool and handoff-call guidance during normal turns while preserving explicit `/handoff <direction>`.
 - Added the extension-owned `/agenticoding-settings` TUI panel for automatic handoff availability. TUI saves are global-only to `~/.pi/agent/settings.json`, preserve unrelated settings keys, persist real booleans, and visibly warn when a project override masks the global value.
-- Manual `/handoff <direction>` now waits behind the scenes when the assistant is streaming, then enables the `handoff` tool and starts a fresh handoff turn once idle. Visible `agenticoding-handoff-diagnostic` conversation messages have been removed from this flow.
+- Manual `/handoff <direction>` now waits behind the scenes when the assistant is streaming, then enables the `handoff` tool and starts a fresh handoff turn once idle. Visible stale-cleanup diagnostics have been removed from this flow, including TUI warnings and `agenticoding-handoff-diagnostic` conversation messages.
 
 ## [0.3.0] - 2026-05-23
 

agenticoding.test.ts

@@ -1072,7 +1072,7 @@ test("handoff compaction error clears pending state and status", async () => {
 	assert.equal(statuses.get(STATUS_KEY_HANDOFF), undefined);
 });
 
-test("turn_end fallback clears stale requested handoff status", async () => {
+test("turn_end fallback silently clears stale requested handoff status", async () => {
 	const pi = new MockPi();
 	registerAgenticoding(pi as any);
 	const statuses = new Map<string, string | undefined>();
@@ -1105,8 +1105,7 @@ test("turn_end fallback clears stale requested handoff status", async () => {
 	});
 
 	assert.equal(statuses.get(STATUS_KEY_HANDOFF), undefined);
-	assert.equal(notifications[0].level, "warning");
-	assert.match(notifications[0].message, /did not call the handoff tool/);
+	assert.deepEqual(notifications, []);
 	assert.deepEqual(pi.sentMessages, []);
 });
 
@@ -1253,7 +1252,7 @@ test("buildNudge handles null percent and boundary hints before topic guidance",
 	assert.match(noTopic, /No active notebook topic is set/);
 });
 
-test("watchdog stale requested handoff cleanup avoids conversation diagnostics", async () => {
+test("watchdog stale requested handoff cleanup stays silent", async () => {
 	const pi = new MockPi();
 	const state = createState();
 	state.pendingRequestedHandoff = { direction: "implement auth", enforcementAttempts: 0, toolCalled: false, awaitingAgentTurn: false };
@@ -1274,8 +1273,7 @@ test("watchdog stale requested handoff cleanup avoids conversation diagnostics",
 	);
 
 	assert.equal(state.pendingRequestedHandoff, null);
-	assert.equal(notifications[0].level, "warning");
-	assert.match(notifications[0].message, /did not call the handoff tool/);
+	assert.deepEqual(notifications, []);
 	assert.deepEqual(pi.sentMessages, []);
 	assert.deepEqual(pi.sentUserMessages, []);
 });

handoff/cleanup.ts

@@ -3,10 +3,6 @@ import type { AgenticodingState } from "../state.js";
 import { STATUS_KEY_HANDOFF } from "../tui.js";
 import { updateHandoffToolAvailability } from "./availability.js";
 
-export function buildMissingRequestedHandoffDiagnostic(direction: string): string {
-	return `Manual /handoff did not compact for direction "${direction}" because the assistant did not call the handoff tool. The temporary handoff tool activation has been cleared.`;
-}
-
 export function emitHandoffDiagnostic(
 	pi: ExtensionAPI,
 	ctx: ExtensionContext,
@@ -27,8 +23,6 @@ export async function clearStaleRequestedHandoff(
 	if (!requested) {
 		return;
 	}
-	const message = buildMissingRequestedHandoffDiagnostic(requested.direction);
-	emitHandoffDiagnostic(pi, ctx, message, "warning");
 	state.pendingRequestedHandoff = null;
 	state.pendingRequestedHandoffPrompt = null;
 	if (ctx.hasUI) {