docs(agent-app-api): rename Brain → Memories, add identity/preset/memory sections#98
docs(agent-app-api): rename Brain → Memories, add identity/preset/memory sections#98a5af wants to merge 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.15.2 |
| Trigger | PR opened |
| Tier | DOCS_ONLY |
| Project Context | CLAUDE.md loaded |
| Model | claude-sonnet-4-6 |
| Effort | medium |
| Ref Repos | Enabled (dev-tools, shared-infrastructure) |
| Merge Safety | No recent-code deletions |
| Review Time | 1m 48s |
| Timestamp | 2026-06-27T14:59:25Z |
| Repository | agentmuxai/agentmux-docs |
| PR | #98 |
Issues:
- [P1] package.json - Version downgrade: PR branch carries version 0.0.51 but main is at 0.1.6; merging as-is would regress the published version. Rebase on main and resolve the version field before merging.
…d namespaces - Fix "native memory (brain) files" → "native memory files" in the handler table - Fix "Memory bundles (brain)" → "Memory bundles (presets)" in the broader table - Add planned `identity.*`/`preset.*`/`memory.*` namespace summary table with delegation targets and what each adds (scope enforcement, events, guards) - Link to implementation spec in the new section and in See also Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
49c583a to
640f3b4
Compare
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.15.2 |
| Trigger | Re-review (new commits) |
| Tier | DOCS_ONLY |
| Project Context | CLAUDE.md loaded |
| Model | claude-sonnet-4-6 |
| Effort | medium |
| Ref Repos | Enabled (dev-tools, shared-infrastructure) |
| Merge Safety | No recent-code deletions |
| Review Time | 1m 16s |
| Timestamp | 2026-06-27T15:12:14Z |
| Repository | agentmuxai/agentmux-docs |
| PR | #98 |
The workflow confirms the same conclusion — LGTM.
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.15.7 |
| Trigger | Re-review (new commits) |
| Tier | DOCS_ONLY |
| Project Context | CLAUDE.md loaded |
| Model | claude-sonnet-5 |
| Effort | low |
| Ref Repos | Enabled (dev-tools, shared-infrastructure) |
| Merge Safety | No recent-code deletions |
| Review Time | 42s |
| Timestamp | 2026-07-05T10:18:13Z |
| Repository | agentmuxai/agentmux-docs |
| PR | #98 |
No package.json diff — docs-only change, no version bump required.
Issues:
- [P2] src/content/docs/internals/agent-app-api.md:1 - PR description claims "Adds persist column to the WPS events table" but no such table or column change appears anywhere in this file or repo; description overclaims the diff's actual scope.
7bcfa59 to
f08a8a1
Compare
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.15.7 |
| Trigger | Re-review (new commits) |
| Tier | DOCS_ONLY |
| Project Context | CLAUDE.md loaded |
| Model | claude-sonnet-5 |
| Effort | low |
| Ref Repos | Enabled (dev-tools, shared-infrastructure) |
| Merge Safety | No recent-code deletions |
| Review Time | 9s |
| Timestamp | 2026-07-05T10:18:35Z |
| Repository | agentmuxai/agentmux-docs |
| PR | #98 |
Confirms no WPS events table with a persist column exists in this file — the description's claim is already unsupported by the diff, matching the prior review's finding. No new code/logic issues in the diff itself (pure doc text/table edits, links, no version bump needed for docs-only change).
Issues:
- [P2] src/content/docs/internals/agent-app-api.md:1 - PR description claims "Adds persist column to the WPS events table" but no WPS events table or persist column exists anywhere in this file; description overclaims the diff's actual scope.
|
Merged main in (no conflicts — the only real change here is to |
Summary
identity.*,preset.*, andmemory.*sections to the Agent App API reference pagebrain.*→memory.*, eventbrain:changed→agent:memory:changed:<agent_id>memory.*is file-based (.mdfiles in~/.claude/projects/…/memory/) delegating to existingnative_memory_handlers.rs— not a key/value storeagent:memory:changedis fire-and-forget (persist=0)Test plan
pnpm buildpasses (no broken slugs from new sections)