Skip to content

Commit 45885e6

Browse files
committed
test(core): improve MessageUtils patch coverage
1 parent 9a3af0e commit 45885e6

2 files changed

Lines changed: 20 additions & 8 deletions

File tree

agentscope-core/src/main/java/io/agentscope/core/util/MessageUtils.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,15 +71,7 @@ public static List<ToolUseBlock> extractRecentToolCalls(List<Msg> messages, Stri
7171
}
7272

7373
private static boolean isCompressedMessage(Msg msg) {
74-
if (msg == null) {
75-
return false;
76-
}
77-
7874
Map<String, Object> metadata = msg.getMetadata();
79-
if (metadata == null) {
80-
return false;
81-
}
82-
8375
return metadata.get(COMPRESS_META_KEY) instanceof Map;
8476
}
8577
}

agentscope-core/src/test/java/io/agentscope/core/util/MessageUtilsTest.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,26 @@ void testExtractRecentToolCallsWithEmptyInput() {
5555
assertTrue(MessageUtils.extractRecentToolCalls(List.of(), "assistant").isEmpty());
5656
}
5757

58+
@Test
59+
@DisplayName("Should not skip assistant messages when _compress_meta is not a map")
60+
void testExtractRecentToolCallsDoesNotSkipAssistantMessagesWithInvalidCompressMetadata() {
61+
Msg message =
62+
createAssistantToolUseMessage(
63+
"real-tool", "real-call", Map.of("_compress_meta", "not-a-map"));
64+
65+
List<ToolUseBlock> toolCalls =
66+
MessageUtils.extractRecentToolCalls(List.of(message), "assistant");
67+
68+
assertEquals(1, toolCalls.size());
69+
assertEquals("real-call", toolCalls.get(0).getId());
70+
}
71+
5872
private Msg createAssistantToolUseMessage(String toolName, String callId) {
73+
return createAssistantToolUseMessage(toolName, callId, Map.of());
74+
}
75+
76+
private Msg createAssistantToolUseMessage(
77+
String toolName, String callId, Map<String, Object> metadata) {
5978
return Msg.builder()
6079
.role(MsgRole.ASSISTANT)
6180
.name("assistant")
@@ -66,6 +85,7 @@ private Msg createAssistantToolUseMessage(String toolName, String callId) {
6685
.id(callId)
6786
.input(new HashMap<>())
6887
.build()))
88+
.metadata(metadata)
6989
.build();
7090
}
7191

0 commit comments

Comments
 (0)