Skip to content

Commit 53a0731

Browse files
authored
fix(rag): Missing the dimension parameter for embedding (#188)
1 parent 12c54ef commit 53a0731

3 files changed

Lines changed: 7 additions & 2 deletions

File tree

agentscope-extensions/agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/embedding/EmbeddingModel.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ public interface EmbeddingModel {
5757

5858
/**
5959
* Get the dimension of embedding vectors produced by this model.
60+
* The default value is 1024 if not specified.
6061
*
6162
* @return the dimension of embedding vectors
6263
*/

agentscope-extensions/agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/embedding/dashscope/DashScopeMultiModalEmbedding.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import io.agentscope.core.message.TextBlock;
3131
import io.agentscope.core.model.ExecutionConfig;
3232
import java.util.List;
33+
import java.util.Map;
3334
import org.slf4j.Logger;
3435
import org.slf4j.LoggerFactory;
3536
import reactor.core.publisher.Mono;
@@ -202,6 +203,7 @@ private MultiModalEmbeddingParam buildTextParam(String text) {
202203
return MultiModalEmbeddingParam.builder()
203204
.apiKey(apiKey)
204205
.model(modelName)
206+
.parameters(Map.of("dimension", dimensions))
205207
.contents(List.of(MultiModalEmbeddingItemText.builder().text(text).build()))
206208
.build();
207209
}
@@ -216,6 +218,7 @@ private MultiModalEmbeddingParam buildImageParam(String imageUrl) {
216218
return MultiModalEmbeddingParam.builder()
217219
.apiKey(apiKey)
218220
.model(modelName)
221+
.parameters(Map.of("dimension", dimensions))
219222
.contents(List.of(MultiModalEmbeddingItemImage.builder().image(imageUrl).build()))
220223
.build();
221224
}
@@ -305,7 +308,7 @@ public int getDimensions() {
305308
public static class Builder {
306309
private String apiKey;
307310
private String modelName;
308-
private int dimensions;
311+
private int dimensions = 1024;
309312
private ExecutionConfig defaultExecutionConfig;
310313
private String baseUrl;
311314

agentscope-extensions/agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/embedding/dashscope/DashScopeTextEmbedding.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ public Mono<double[]> embed(ContentBlock block) {
119119
TextEmbeddingParam.builder()
120120
.apiKey(apiKey)
121121
.model(modelName)
122+
.dimension(dimensions)
122123
.texts(List.of(text))
123124
.build();
124125

@@ -216,7 +217,7 @@ public int getDimensions() {
216217
public static class Builder {
217218
private String apiKey;
218219
private String modelName;
219-
private int dimensions;
220+
private int dimensions = 1024;
220221
private ExecutionConfig defaultExecutionConfig;
221222
private String baseUrl;
222223

0 commit comments

Comments
 (0)