fix(mysql-session): commit writes when auto-commit is disabled#1111
Open
Alexxigang wants to merge 5 commits intoagentscope-ai:mainfrom
Open
fix(mysql-session): commit writes when auto-commit is disabled#1111Alexxigang wants to merge 5 commits intoagentscope-ai:mainfrom
Alexxigang wants to merge 5 commits intoagentscope-ai:mainfrom
Conversation
Contributor
Author
|
Friendly ping on this PR when maintainers have time. The fix and validation are ready on my side, and I'm happy to make any follow-up adjustments if review feedback comes in. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MysqlSessionwrite paths use consistent transactional behavior when connections start withautoCommit=falsetrueWhy this fix
MysqlSession.save(...)previously committed the full-rewrite list path manually, but left append writes and other write paths relying on the connection's default auto-commit behavior. When a datasource returns connections withautoCommit=false, those writes can be lost. The previous full-rewrite path also mutated the connection state by always restoringautoCommit=true.This change routes write operations through a shared transactional helper so the module commits its own writes consistently and only restores the connection state when it actually changed it.
Closes #1087.
Validation
mvn -pl agentscope-extensions/agentscope-extensions-session-mysql -am -DskipTests test-compilemvn -pl agentscope-extensions/agentscope-extensions-session-mysql -am "-Dtest=MysqlSessionTest,MysqlSessionE2ETest" "-Dsurefire.failIfNoSpecifiedTests=false" test