Skip to content

fix(core): fix list hash stability for equivalent messages #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Weilong-Qin wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(core): fix list hash stability for equivalent messages #1364

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d4bbd6
fix(core): fix list hash stability for equivalent messages
Weilong-Qin May 9, 2026
774b4cd
Move ListHashUtil hash test to core
Weilong-Qin May 9, 2026
a0f5e43
Merge branch 'agentscope-ai:main' into fix/unstable-computehash
Weilong-Qin May 11, 2026
0392f38
refactor(core): add value-based equals and hashCode methods to the Ms…
Weilong-Qin May 12, 2026
004b226
Merge remote-tracking branch 'origin/fix/unstable-computehash' into f…
Weilong-Qin May 12, 2026
cd4e0fe
test(core): add test
Weilong-Qin May 13, 2026
a94bbb0
test(core): add Msg test
Weilong-Qin May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion agentscope-core/src/main/java/io/agentscope/core/session/ListHashUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package io.agentscope.core.session;

import io.agentscope.core.state.State;
import io.agentscope.core.util.JsonUtils;
import java.util.List;

/**
Expand Down Expand Up @@ -88,7 +89,7 @@ public static String computeHash(List<? extends State> values) {

for (int idx : sampleIndices) {
State item = values.get(idx);
int itemHash = item != null ? item.hashCode() : 0;
int itemHash = item != null ? JsonUtils.getJsonCodec().toJson(item).hashCode() : 0;
sb.append(idx).append(":").append(itemHash).append(",");
Comment on lines 89 to 92
}

Expand Down
43 changes: 43 additions & 0 deletions ...nsions-session-mysql/src/test/java/io/agentscope/core/session/mysql/MysqlSessionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import io.agentscope.core.message.Msg;
import io.agentscope.core.message.MsgRole;
import io.agentscope.core.message.TextBlock;
import io.agentscope.core.session.ListHashUtil;
import io.agentscope.core.state.SessionKey;
import io.agentscope.core.state.SimpleSessionKey;
import io.agentscope.core.state.State;
Expand Down Expand Up @@ -282,6 +286,45 @@ void testSaveAndGetListState() throws SQLException {
assertEquals("value2", loaded.get(1).value());
}

@Test
@DisplayName("Should compute same hash for equivalent message lists")
void testComputeHashEquivalentMessageLists() {
List<Msg> first =
List.of(
Comment thread
Weilong-Qin marked this conversation as resolved.
Outdated
Msg.builder()
.id("m-user-1")
.timestamp("2026-05-08 14:00:00.000")
.role(MsgRole.USER)
.content(TextBlock.builder().text("hello").build())
.build(),
Msg.builder()
.id("m-assistant-1")
.timestamp("2026-05-08 14:00:01.000")
.role(MsgRole.ASSISTANT)
.content(TextBlock.builder().text("hello").build())
.build());

List<Msg> second =
List.of(
Msg.builder()
.id("m-user-1")
.timestamp("2026-05-08 14:00:00.000")
.role(MsgRole.USER)
.content(TextBlock.builder().text("hello").build())
.build(),
Msg.builder()
.id("m-assistant-1")
.timestamp("2026-05-08 14:00:01.000")
.role(MsgRole.ASSISTANT)
.content(TextBlock.builder().text("hello").build())
.build());

String h1 = ListHashUtil.computeHash(first);
String h2 = ListHashUtil.computeHash(second);

assertEquals(h1, h2);
}

@Test
@DisplayName("Should commit incremental list save when connection auto-commit is disabled")
void testSaveListIncrementalAppendCommitsWhenAutoCommitDisabled() throws SQLException {
Expand Down
Loading