feat(mysql): add MysqlSkillRepository and associated tests for skill … by jianjun159 · Pull Request #600 · agentscope-ai/agentscope-java

jianjun159 · 2026-01-19T07:53:42Z

…management

AgentScope-Java Version

[The version of AgentScope-Java you are working on, e.g. 1.0.7, check your pom.xml dependency version or run mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]

version: 1.0.7

Description

[Please describe the background, purpose, changes made, and how to test this PR]

feat(mysql): add MysqlSkillRepository and associated tests for skill management #599

Checklist

Please check the following items before code is ready to be reviewed.

Code has been formatted with mvn spotless:apply
All tests are passing (mvn test)
Javadoc comments are complete and follow project conventions
Related documentation has been updated (e.g. links, examples, etc.)
Code is ready for review

…management

gemini-code-assist · 2026-01-19T07:53:58Z

Summary of Changes

Hello @jianjun159, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the AgentScope-Java framework by integrating MySQL as a persistent storage solution for agent skills. It provides a robust and secure mechanism for managing skill metadata and associated resources, allowing for scalable and reliable skill management within AgentScope applications. This addition expands the data persistence options available for AgentScope components.

Highlights

New Module Introduction: A new Maven module, agentscope-extensions-skill-mysql, has been added to provide MySQL database integration for skill management.
MySQL Skill Repository Implementation: The MysqlSkillRepository class implements the AgentSkillRepository interface, enabling AgentSkill objects and their associated resources to be stored, retrieved, updated, and deleted in a MySQL database.
Robust Database Operations: The repository supports automatic table creation, full CRUD operations, transaction management for atomic operations, and robust identifier validation to prevent SQL injection vulnerabilities.
Flexible Configuration: A builder pattern is provided for flexible configuration of the MysqlSkillRepository, allowing customization of database and table names, and read/write permissions.
Comprehensive Unit Testing: Extensive unit tests have been added to cover constructor behavior, CRUD operations, read-only mode, repository information, and critical SQL injection prevention mechanisms.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a MysqlSkillRepository for persisting agent skills in a MySQL database. The implementation is robust, with good practices like using a builder pattern, transaction management, and validation to prevent SQL injection. The accompanying unit tests are comprehensive and well-structured.

I've identified a few areas for improvement, primarily concerning data integrity, performance, and transactional behavior. My key recommendations are:

Enforcing data integrity by adding the documented foreign key constraint to the database schema.
Optimizing the getAllSkills method to resolve an N+1 query issue.
Revisiting the transaction logic in the save method to handle lists of skills more predictably.
A minor performance enhancement in resource insertion and a correction in the corresponding unit test.

Overall, this is a solid contribution. Addressing these points will make the repository more performant and resilient.

codecov · 2026-01-19T07:59:58Z

Codecov Report

❌ Patch coverage is 72.92818% with 98 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...e/skill/repository/mysql/MysqlSkillRepository.java	72.92%	87 Missing and 11 partials ⚠️

📢 Thoughts on this report? Let us know!

…management

AlbumenJ

@fang-tech PTAL

fang-tech · 2026-01-21T09:11:35Z

@fang-tech PTAL

👌

# Conflicts: # docs/en/task/agent-skill.md # docs/zh/task/agent-skill.md

fang-tech

LGTM, tks for your contribution!

…nd update documentation

…onfiguration

fang-tech · 2026-01-29T10:59:02Z

Update the unnecessary modifications in the English document

…disclosure of tools

jianjun159 · 2026-01-29T11:11:52Z

Update the unnecessary modifications in the English document

Ok. Now the content of the Chinese document and the English document is consistent

fang-tech · 2026-01-30T01:52:54Z

@AlbumenJ help to merge

LearningGp · 2026-03-04T02:38:48Z

# Conflicts: # agentscope-distribution/agentscope-all/pom.xml

jianjun159 · 2026-03-09T04:18:14Z

The latest branch code has been merged and this conflict has been resolved

LearningGp · 2026-03-10T02:47:33Z

Please ensure all review comments are resolved before we proceed. Kindly take another look.

jianjun159 · 2026-03-10T06:04:19Z

Please ensure all review comments are resolved before we proceed. Kindly take another look.

All the review comments have been resolved. Thank you for your review

LearningGp

LGTM

fang-tech · 2026-03-17T07:26:34Z

Thx for your contribution! Great job!

agentscope-ai#600) …management ## AgentScope-Java Version [The version of AgentScope-Java you are working on, e.g. 1.0.7, check your pom.xml dependency version or run `mvn dependency:tree | grep agentscope-parent:pom`(only mac/linux)] version: 1.0.7 ## Description [Please describe the background, purpose, changes made, and how to test this PR] feat(mysql): add MysqlSkillRepository and associated tests for skill management agentscope-ai#599 ## Checklist Please check the following items before code is ready to be reviewed. - [x] Code has been formatted with `mvn spotless:apply` - [x] All tests are passing (`mvn test`) - [x] Javadoc comments are complete and follow project conventions - [x] Related documentation has been updated (e.g. links, examples, etc.) - [x] Code is ready for review --------- Co-authored-by: jianjun.xu <jianjun.xu@ly.com>

feat(mysql): add MysqlSkillRepository and associated tests for skill …

e333676

…management

jianjun159 requested a review from a team January 19, 2026 07:53

gemini-code-assist Bot reviewed Jan 19, 2026

View reviewed changes

jianjun159 added 3 commits January 19, 2026 16:28

feat(mysql): add MysqlSkillRepository and associated tests for skill …

ba6258f

…management

feat(mysql): add MysqlSkillRepository and associated tests for skill …

a54a7ca

…management

Merge branch 'main' into skill_mysql

0908e20

AlbumenJ reviewed Jan 21, 2026

View reviewed changes

Merge branch 'main' into skill_mysql

88ec074

fang-tech requested changes Jan 27, 2026

View reviewed changes

Comment thread docs/zh/task/agent-skill.md Outdated

Comment thread docs/zh/task/agent-skill.md Outdated

Comment thread agentscope-extensions/agentscope-extensions-skill-mysql/pom.xml Outdated

jianjun159 added 3 commits January 28, 2026 20:00

docs(mysql): update MySQL storage documentation and rename artifact

86baf50

Merge remote-tracking branch 'origin/main' into skill_mysql

edb8336

# Conflicts: # docs/en/task/agent-skill.md # docs/zh/task/agent-skill.md

docs(mysql): update MySQL storage documentation and rename artifact

13aae12

fang-tech reviewed Jan 28, 2026

View reviewed changes

jianjun159 added 2 commits January 29, 2026 09:59

Merge branch 'main' into skill_mysql

400f274

refactor(mysql): enhance MysqlSkillRepository with full constructor a…

917aa32

…nd update documentation

fang-tech reviewed Jan 29, 2026

View reviewed changes

refactor(mysql): implement Builder pattern for MysqlSkillRepository c…

4901390

…onfiguration

docs(mysql): update agent-skill documentation to include progressive …

e828ee8

…disclosure of tools

LearningGp reviewed Mar 4, 2026

View reviewed changes

Comment thread ...repository/src/main/java/io/agentscope/core/skill/repository/mysql/MysqlSkillRepository.java

Merge branch 'main' into skill_mysql

fbfb59f

# Conflicts: # agentscope-distribution/agentscope-all/pom.xml

Merge branch 'agentscope-ai:main' into skill_mysql

75047b9

fix(skills): prevent clearing skills in read-only mode

0ad5561

LearningGp approved these changes Mar 13, 2026

View reviewed changes

fang-tech reviewed Mar 13, 2026

View reviewed changes

tclxjianjun-xu added 2 commits March 16, 2026 14:43

Merge remote-tracking branch 'origin/main' into skill_mysql

cb395f7

refactor(skills): rename skill_id to id in database schema and queries

6917c03

fang-tech approved these changes Mar 17, 2026

View reviewed changes

LearningGp merged commit bdad871 into agentscope-ai:main Mar 17, 2026
8 of 10 checks passed

Conversation

jianjun159 commented Jan 19, 2026

AgentScope-Java Version

Description

Checklist

Uh oh!

gemini-code-assist Bot commented Jan 19, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AlbumenJ left a comment

Choose a reason for hiding this comment

Uh oh!

fang-tech commented Jan 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fang-tech left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fang-tech commented Jan 29, 2026

Uh oh!

jianjun159 commented Jan 29, 2026

Uh oh!

fang-tech commented Jan 30, 2026

Uh oh!

Uh oh!

LearningGp commented Mar 4, 2026

Uh oh!

jianjun159 commented Mar 9, 2026

Uh oh!

LearningGp commented Mar 10, 2026

Uh oh!

jianjun159 commented Mar 10, 2026

Uh oh!

LearningGp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fang-tech commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

codecov Bot commented Jan 19, 2026 •

edited

Loading