Skip to content

fix(core): When ReactAgent reach maxIters, msg contains MAX_ITERATIONS #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LearningGp merged 3 commits into from
Mar 4, 2026
Merged

fix(core): When ReactAgent reach maxIters, msg contains MAX_ITERATIONS #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fd3373
fix(core): When ReactAgent reach maxIters, msg contains MAX_ITERATIONS
aihai Feb 27, 2026
587e1d6
fix(core): When ReactAgent reach maxIters, msg contains MAX_ITERATIONS
aihai Feb 27, 2026
d694a85
Merge branch 'main' into fix-ReactAgent-reach-maxIters-Msg-not-contai…
LearningGp Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,10 @@ protected Mono<Msg> summarizing() {
postEvent -> {
Msg finalMsg =
postEvent
.getSummaryMessage();
.getSummaryMessage()
.withGenerateReason(
GenerateReason
.MAX_ITERATIONS);
memory.addMessage(finalMsg);
return finalMsg;
}));
Expand Down
11 changes: 8 additions & 3 deletions agentscope-core/src/test/java/io/agentscope/core/agent/ReActAgentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import io.agentscope.core.agent.test.TestUtils;
import io.agentscope.core.memory.InMemoryMemory;
import io.agentscope.core.message.ContentBlock;
import io.agentscope.core.message.GenerateReason;
import io.agentscope.core.message.Msg;
import io.agentscope.core.message.MsgRole;
import io.agentscope.core.message.TextBlock;
Expand Down Expand Up @@ -476,9 +477,13 @@ void testMaxIterations() {

// Get response with timeout
// Verify it completes within reasonable time (not infinite loop)
agent.call(userMsg)
.timeout(Duration.ofMillis(TestConstants.DEFAULT_TEST_TIMEOUT_MS))
.block(Duration.ofMillis(TestConstants.DEFAULT_TEST_TIMEOUT_MS));
Msg response =
agent.call(userMsg)
.timeout(Duration.ofMillis(TestConstants.DEFAULT_TEST_TIMEOUT_MS))
.block(Duration.ofMillis(TestConstants.DEFAULT_TEST_TIMEOUT_MS));

// Verify max iterations generate reason was respected
assertEquals(GenerateReason.MAX_ITERATIONS, response.getGenerateReason());

// Verify max iterations was respected
assertTrue(
Expand Down
Loading