fix(skill): skillBox prompt should merge into system prompts#895
Merged
LearningGp merged 2 commits intoMar 11, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes issue #845 where using skillBox() alongside sysPrompt() could produce multiple SYSTEM messages, which some model providers reject (e.g., “System message must be at the beginning.”).
Changes:
- Update
SkillHookto merge the skill prompt into an existingSYSTEMmessage when present, instead of always prepending a newSYSTEMmessage. - Adjust existing tests and add a new regression test for issue #845 behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/skill/SkillHook.java | Merges skill prompt into an existing SYSTEM message (or prepends one if none exists). |
| agentscope-core/src/test/java/io/agentscope/core/skill/SkillHookTest.java | Updates the “inject at first” test and adds a new test to validate merging behavior for #845. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
fang-tech
changed the title
|
rag召回的数据也是额外的一个单独的system提示词，是不是也要统一放到一个system提示词里。 |
liangxingguang
pushed a commit
to liangxingguang/agentscope-java
that referenced
this pull request
May 21, 2026
…ope-ai#895) ## AgentScope-Java Version [The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run `mvn dependency:tree | grep agentscope-parent:pom`(only mac/linux)] ## Description fix & close agentscope-ai#845 ## Checklist Please check the following items before code is ready to be reviewed. - [x] Code has been formatted with `mvn spotless:apply` - [x] All tests are passing (`mvn test`) - [x] Javadoc comments are complete and follow project conventions - [x] Related documentation has been updated (e.g. links, examples, etc.) - [x] Code is ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
fix & close #845
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)