fix(skill): skill fileSystem base repo source should not contain :#896
Merged
LearningGp merged 1 commit intoMar 11, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows InvalidPathException when skill IDs are used as directory names by removing : from the default source strings produced by skill repositories.
Changes:
- Change default
sourceformats fromfilesystem:*/classpath:*tofilesystem-*/classpath-*. - Update repository unit tests to assert the new default source formats.
- Expand
FileSystemSkillRepositoryTestwith save-related tests, including a check that the computed source contains no colon.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/skill/repository/FileSystemSkillRepository.java | Changes default getSource() prefix to avoid : in generated skill IDs on Windows. |
| agentscope-core/src/main/java/io/agentscope/core/skill/repository/ClasspathSkillRepository.java | Changes default source generation to use classpath- instead of classpath:. |
| agentscope-core/src/test/java/io/agentscope/core/skill/repository/FileSystemSkillRepositoryTest.java | Updates source assertions and adds save/overwrite/resources tests plus a “no colon” assertion. |
| agentscope-core/src/test/java/io/agentscope/core/skill/repository/ClasspathSkillRepositoryTest.java | Updates default source expectations to the new classpath-* format. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
fang-tech
changed the title
Collaborator
|
liangxingguang
pushed a commit
to liangxingguang/agentscope-java
that referenced
this pull request
May 21, 2026
…gentscope-ai#896) ## AgentScope-Java Version [The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run `mvn dependency:tree | grep agentscope-parent:pom`(only mac/linux)] ## Description close agentscope-ai#842 ## Checklist Please check the following items before code is ready to be reviewed. - [x] Code has been formatted with `mvn spotless:apply` - [x] All tests are passing (`mvn test`) - [x] Javadoc comments are complete and follow project conventions - [x] Related documentation has been updated (e.g. links, examples, etc.) - [x] Code is ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
close #842
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)