Skip to content

Fix rp1 camera#1436

Open
gizahNL wants to merge 3 commits into
agherzan:masterfrom
gizahNL:fix-rp1-camera
Open

Fix rp1 camera#1436
gizahNL wants to merge 3 commits into
agherzan:masterfrom
gizahNL:fix-rp1-camera

Conversation

@gizahNL

@gizahNL gizahNL commented Mar 14, 2025

Copy link
Copy Markdown

Fixes #1303

- What I did
Use RPI foundation libcamera, install libpisp, upgrade libcamera-apps

Please take a look whether this is the best way to integrate this.

@gizahNL gizahNL changed the title Draft: Fix rp1 camera Fix rp1 camera Mar 21, 2025
@gizahNL

gizahNL commented Apr 8, 2025

Copy link
Copy Markdown
Author

@kraj @agherzan could either of you get a look out on this? Would be nice to know if this is the right direction according to you guys?

And in my testing getting libpisp installed and used by libcamera was the only way to get cam support working on the RPI CM5 I have on my desk....

@kraj kraj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be good to apply the needed patches on top of upstream libcamera, is that possible ?

@agherzan

Copy link
Copy Markdown
Owner

@gizahNL This looks fine to me the way it is. Could you check the commits and clean them up a bit using the guidelines in https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html. For example, the Signed-Off-By missing footers.

@jwinarske

Copy link
Copy Markdown
Contributor

I think it will be good to apply the needed patches on top of upstream libcamera, is that possible ?

@kraj it’s not. The raspberry libcamera repo is a fork and is required to be used with raspberry pi Linux kernel. The mainline libcamera only works when using mainline Linux kernel, and vice versa. Unclear why the two aren’t in sync.

@gizahNL you’re not setting the ipas build flag, which means you’re running the plugin in a sandbox; lower perf. Setting pipeline to auto also adds all, when you only need one of two. Preferable is only set one based on machine. It will enumerate all at runtime for each call; enable debug logs to see behavior.

I came up with similar recipes two days ago; didn’t see this issue, yet they’re a bit less. No disable warnings, etc; it builds fine.

@jwinarske

Copy link
Copy Markdown
Contributor

My PR: #1517
Addresses all open camera issues and rolls recipes to latest release

@gizahNL

gizahNL commented Aug 29, 2025

Copy link
Copy Markdown
Author

@gizahNL you’re not setting the ipas build flag, which means you’re running the plugin in a sandbox; lower perf. Setting pipeline to auto also adds all, when you only need one of two. Preferable is only set one based on machine. It will enumerate all at runtime for each call; enable debug logs to see behavior.

It's set at line 28 & 30 of the libcamera bbappend ;)

Gijs Peskens added 3 commits August 29, 2025 10:31
Signed-off-by: Gijs Peskens <gijs.peskens@munisense.com>
These contain changes not yet in libcamera upstream supporting rpi/pisp,
required for RPi5/CM5 camera support.

Signed-off-by: Gijs Peskens <gijs.peskens@munisense.com>
Signed-off-by: Gijs Peskens <gijs.peskens@munisense.com>
@gizahNL

gizahNL commented Aug 29, 2025

Copy link
Copy Markdown
Author

@agherzan PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raspberry 5 camera doesn't work

4 participants