Fix compilation of Cairo on Whinlatter when not using VC4 graphics#1564
Open
gizahNL wants to merge 2 commits into
Open
Fix compilation of Cairo on Whinlatter when not using VC4 graphics#1564gizahNL wants to merge 2 commits into
gizahNL wants to merge 2 commits into
Conversation
kraj
requested changes
Jan 9, 2026
Signed-off-by: Gijs Peskens <gijs.peskens@munisense.com>
gizahNL
force-pushed
the
cairo_fix_whinlatter_compilation
branch
from
January 16, 2026 10:45
af77f8a to
3a8c81a
Compare
agherzan
approved these changes
Jan 25, 2026
agherzan
left a comment
agherzan
left a comment
Owner
There was a problem hiding this comment.
Thanks! Looks fine to me. I could have used a bit more context on the details of the issue in the git log. As it stands right now, it's a bit of a stab in the dark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes compilation of cairo on Whinlatter when not using VC4 graphics.
- How I did it
Comment out flags no longer used on the main recipe, no further testing besides "does it build"