rpidistro-vlc: Upgrade to latest, 3.0.22, upstream#1576
Conversation
|
@gizahNL Thank you so much for picking up the mantel of responsibility! :) Haven't had the motivation since I've mostly been working with x64 cpu's for the past 3 years. |
gizahNL
changed the title
agherzan
left a comment
agherzan
left a comment
There was a problem hiding this comment.
Huge work. Thanks for taking this.
My pleasure ;) Necessity motivates! :) I'm not sure the failing tests are related to my MR, the pi0-wifi systemd tests fails on psplash, the DCO test with an unknown error (it's not displayed) |
gizahNL
changed the title
Recipe has been changed to better reflect OE VLC recipe Signed-off-by: Gijs Peskens <gijs.peskens@munisense.com>
|
Could someone take a look at this? Would be nice if it got merged ;) (yes I understand the patchset is huuuuge, perhaps comparing with the "official" vlc patchset from RPI would be good?) |
This comment was marked as outdated.
This comment was marked as outdated.
| stream_t *s = (stream_t *)vlclua_get_this(L); | ||
| - int n = luaL_checkint( L, 1 ); | ||
| + int n = luaL_checkinteger( L, 1 ); | ||
| + int n = luaL_checkintegereger( L, 1 ); |
There was a problem hiding this comment.
luaL_checkintegereger ? Is this correct (and not a copy-paste error)? Same question for all other occurrences
| ac_cv_path_MOC=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/moc \ | ||
| ac_cv_path_RCC=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/rcc \ | ||
| ac_cv_path_UIC=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/uic \ | ||
| " |
There was a problem hiding this comment.
Small nitpick: these variables usually go to CACHED_CONFIGUREVARS (though now I see that the vlc recipe in meta-oe uses the same... oh well)
| udev \ | ||
| alsa harfbuzz jack neon v4l2 drm \ | ||
| " | ||
| inherit ${@bb.utils.contains('PACKAGECONFIG', 'qt5', 'qmake5_paths', '', d)} |
There was a problem hiding this comment.
Could this and the other inherit directive be moved closer to each other?
| libmtp libopus orc libsamplerate0 libusb1 schroedinger taglib \ | ||
| tiff" | ||
|
|
||
| inherit autotools-brokensep features_check gettext pkgconfig mime-xdg |
There was a problem hiding this comment.
Bitbake grumbles a bit: WARNING: Recipe inherits features_check but doesn't use it
| } | ||
|
|
||
| # This recipe packages vlc as a library as well, so qt4 dependencies | ||
| # can be avoided when only the library is installed. |
There was a problem hiding this comment.
I think that qt4 in the comment should be just qt, so it gets obsolete less frequently.
| PACKAGECONFIG[dv1394] = "--enable-dv1394,--disable-dv1394,libraw1394 libavc1394" | ||
| PACKAGECONFIG[svg] = "--enable-svg,--disable-svg,librsvg" | ||
| PACKAGECONFIG[svgdec] = "--enable-svgdec,--disable-svgdec,librsvg cairo" | ||
| PACKAGECONFIG[notify] = "--enable-notify,--disable-notify, libnotify" |
There was a problem hiding this comment.
Found this after my configure failure comment: the previous version also added gtk+3 as a dependency for notify, which is missing from this version. Adding it fixes do_configure on my machine (TM)
|
One more comment, with 2 thoughts:
I'm using the following packageconfig (which is the default from the recipe):
|
| char *buf = malloc(n); | ||
|
|
||
| if (buf != NULL) | ||
| --- a/modules/lua/libs/net.c |
There was a problem hiding this comment.
(Apologies for the spam...)
Should this whole portion (for modules/lua/libs/net.c & co) of the patch be removed also? Looking at the source, I would assume that the changes are still required.
4 participants
Recipe has been changed to better reflect OE VLC recipe
The biggest feature is full HW acceleration when using v3d driver, with zero copy video output via vout_drm
Compilation has been tested both with and without v3d driver setting.