Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.

Type ingress.annotations as a map#6

Open
GeertJohan wants to merge 1 commit into
agoda-com:masterfrom
GeertJohan:patch-2
Open

Type ingress.annotations as a map#6
GeertJohan wants to merge 1 commit into
agoda-com:masterfrom
GeertJohan:patch-2

Conversation

@GeertJohan
Copy link
Copy Markdown

Thanks for this awesome project!

By making annotations an empty map, it still clasified as empty in the if/else in ingress.yaml, but allows a user to add values using --set.
e.g.:

helm install --namespace openstf --name openstf \
    -f android-farm/openstf/values.yaml \
    --set \
ingress.annotations."nginx\.org/websocket-services"=openstf-openstf-nginx,\
ingress.annotations."nginx\.ingress\.kubernetes\.io/auth-type"=basic,\
ingress.annotations."nginx\.ingress\.kubernetes\.io/auth-secret"=basic-auth,\
ingress.annotations."nginx\.ingress\.kubernetes\.io/auth-realm"="Authentication Required - foo" \
    ./android-farm/openstf

Without the {}, helm fails to parse the --set values for ingress.annotations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant