Skip to content

Stop pre-commit from pushing to PRs for autofixes#303

Merged
agriyakhetarpal merged 1 commit intomainfrom
stop-autofixing-prs
Apr 26, 2026
Merged

Stop pre-commit from pushing to PRs for autofixes#303
agriyakhetarpal merged 1 commit intomainfrom
stop-autofixing-prs

Conversation

@agriyakhetarpal
Copy link
Copy Markdown
Owner

It's not that useful from a security standpoint, and it also causes the dreaded feedback loop where an automated commit emerges on remote branches where I'm actively working and I suddenly need to pull in new changes before I can push my commits. Just asking the bot to fix the failures in a comment is so much better.

@agriyakhetarpal agriyakhetarpal requested a review from ulgens April 26, 2026 04:31
@agriyakhetarpal agriyakhetarpal enabled auto-merge (squash) April 26, 2026 04:32
@agriyakhetarpal agriyakhetarpal merged commit 4d73830 into main Apr 26, 2026
28 checks passed
@agriyakhetarpal agriyakhetarpal deleted the stop-autofixing-prs branch April 26, 2026 07:52
@ulgens
Copy link
Copy Markdown
Collaborator

ulgens commented Apr 26, 2026

Makes sense. If we are goign into this direction, I guess we can completely disable the external service and handle it in GHA, but that would be another step.

@agriyakhetarpal
Copy link
Copy Markdown
Owner Author

Hmm, I would be okay with that in principle, but I would miss the automated hook updates 😅

@ulgens
Copy link
Copy Markdown
Collaborator

ulgens commented Apr 26, 2026

@agriyakhetarpal I was thinking of renovate for the updates.

@agriyakhetarpal
Copy link
Copy Markdown
Owner Author

Oh, it's great that it can update pre-commit hooks, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants