Allow CMake 3.x with zlib 1.3.2#80
Open
TheNicker wants to merge 2 commits into
Open
Conversation
added 2 commits
May 14, 2026 18:43
The zlib external project links FreeImage against the installed static library, but Ninja needs that generated file declared on the install step. Record the platform-specific zlib library name and expose it through INSTALL_BYPRODUCTS while still deriving ZLIB_ROOT from the ExternalProject install directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #77.
This PR contains two separate zlib-related fixes.
First, the project currently requires CMake 4.2 because that version's
FindZLIBmodule recognizes zlib 1.3.2's Windows static library names,zs.libandzsd.lib. That lookup detail is local to the bundled zlib dependency, so this PR keeps the CMake minimum in the 3.x line and passes the exact zlib library path to downstream dependency builds that callfind_package(ZLIB).Second, clean Ninja builds need the installed zlib static library to be declared as an
ExternalProjectbyproduct. This issue is independent of CMake 4.2's ability to find zlib: even when the correct zlib library path is known, Ninja still needs a build rule that says the zlib install step produces that file beforeFreeImagelinks against it.Changes
3.28...4.2.zs/zsdWindows static library naming.dependency.zlib.cmake.ZLIB_LIBRARYto PNG, TIFF, HEIF, and JPEG XL dependency builds.ExternalProjectINSTALL_BYPRODUCTSoutput so Ninja can order clean builds correctly.