Skip to content

Commit 3322f0a

Browse files
authored
Mark SOCKET_WEBRTC as deprecated (emscripten-core#27371)
See emscripten-core#27366 If we don't get any feedback after a few releases we can followup with emscripten-core#27367.
1 parent 44d9f22 commit 3322f0a

3 files changed

Lines changed: 5 additions & 0 deletions

File tree

site/source/docs/tools_reference/settings_reference.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -563,6 +563,8 @@ You can set 'subprotocol' to null, if you don't want to specify it.
563563
Run time configuration may be useful as it lets an application select
564564
multiple different services.
565565

566+
.. note:: This setting is deprecated
567+
566568
Default value: false
567569

568570
.. _websocket_url:
@@ -3542,6 +3544,7 @@ these settings please open a bug (or reply to one of the existing bugs).
35423544
- ``DETERMINISTIC``: under consideration for removal (https://github.com/emscripten-core/emscripten/issues/26647)
35433545
- ``USE_PTHREADS``: prefer the standard -pthread flag
35443546
- ``MEMORY64``: prefer the standard -m64 or --target=wasm64 flags
3547+
- ``SOCKET_WEBRTC``: under consideration for removal (https://github.com/emscripten-core/emscripten/issues/27366)
35453548

35463549
.. _legacy-settings:
35473550

src/settings.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,7 @@ var FS_DEBUG = false;
404404
// Run time configuration may be useful as it lets an application select
405405
// multiple different services.
406406
// [link]
407+
// [deprecated]
407408
var SOCKET_WEBRTC = false;
408409

409410
// A string containing either a WebSocket URL prefix (ws:// or wss://) or a

tools/settings.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
'DETERMINISTIC': 'under consideration for removal (https://github.com/emscripten-core/emscripten/issues/26647)',
118118
'USE_PTHREADS': 'prefer the standard -pthread flag',
119119
'MEMORY64': 'prefer the standard -m64 or --target=wasm64 flags',
120+
'SOCKET_WEBRTC': 'under consideration for removal (https://github.com/emscripten-core/emscripten/issues/27366)',
120121
}
121122

122123
# Settings that don't need to be externalized when serializing to json because they

0 commit comments

Comments
 (0)