Birmingham | Data flows | Ahmad Ehsas

[ahmadehsas]

Link to Kata:

https://codeyourfuture.github.io/Codewars-Progress-Checker/#ahmadehsas

link to Deployed Netlify site:

https://cyf-ahmadehsas-tv.netlify.app

Link to Github repo:

https://github.com/ahmadehsas/Project-TV-Show

Link to level-400 TV-Show-Project:

asaniDev/Project-TV-Show#12

Link to level-500 TV-Show-Project:

ahmadehsas/Project-TV-Show#5

Link to Book library:

CodeYourFuture/Module-Data-Flows#339

Link to my issue for LinkedIn social selling index:

#96

Link of Screen Shot:

Screenshot of Demo:

[cjyuan]

The link to the deployed page on Netlify is incorrect; it should be a link in the format specified in the Level-0 spec.

[ahmadehsas]

Thanks for pointing this out. I’ve updated the issue with the correct public Netlify deployment link.

[cjyuan]

• I expect to find a search field for shows on the show listing page, but I could not find it.

• After selecting the show "24", and then selecting an episode from the dropdown list, I expect to see only the selected episode. Instead, no show got listed.

• Any reason to place the dropdown list of shows at the bottom of the page?

Please note that there is a quota for deploying our page on Netlfiy per day. If you deploy your changes too many times per day, Netlify will temporarily suspend the deployment.

[ahmadehsas]

Can you give me any advice? Should I address these issues in the main branch or create a separate branch?

[cjyuan]

The first two items are part of the requirements. You nee to address them so that your app meets the requirement of the TV Show project.

You can create a separate branch, but eventually you would need to merge the branch to main as main is supposed to represent the "released version". You should fully test your implementation on your own computer first before pushing your change to GitHub.

[ahmadehsas]

I’ve addressed the points you raised:

Added a show search field on the show listing page.

Fixed the episode dropdown, so selecting an episode now correctly displays only that episode.

Moved the show dropdown and search to the top of the page for better visibility.

[illicitonion]

Thanks for these fixes - I will approve your step, but here is some feedback on your TV Show project you should still work on:

1. The styling makes the website quite hard to use on a computer. The individual episode cards are very large, and the show list doesn't make very good use of space (only showing 1.5 shows at a time on one screen).
2. If no results are found in a search, it just shows a red box with no text.
3. Your site has an XSS vulnerability due to its use of inner HTML with untrusted input - have a read of https://medium.com/@sparklewebhelp/understanding-the-risks-of-using-inner-html-in-web-development-30d4fa67f815 and try to fix this in your site.
4. You implement show filtering twice, which means if you wanted to change it (e.g. to make it case sensitive), you would need to change it in two places. See if you can make it so you'd only need to change one place.