Merge pull request #376 from ahx/fix-test-no-raise-invalid-request

Fix test no raise invalid request

Author: ahx

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 2.9.1
+
+- Fix OpenapiFirst::Test's request validation to not always raise an error, but only for unknown requests
+
 ## 2.9.0
 
 - OpenapiFirst::Test now raises an error for unknown requests. You can deactivate with:

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    openapi_first (2.9.0)
+    openapi_first (2.9.1)
       hana (~> 1.3)
       json_schemer (>= 2.1, < 3.0)
       openapi_parameters (>= 0.5.1, < 2.0)

benchmarks/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    openapi_first (2.9.0)
+    openapi_first (2.9.1)
       hana (~> 1.3)
       json_schemer (>= 2.1, < 3.0)
       openapi_parameters (>= 0.5.1, < 2.0)

lib/openapi_first/test.rb

@@ -118,7 +118,7 @@ def self.install
 
     def self.raise_request_error?(validated_request)
       return false if validated_request.valid?
-      return true if validated_request.known?
+      return false if validated_request.known?
 
       !configuration.ignore_unknown_requests
     end

lib/openapi_first/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenapiFirst
-  VERSION = '2.9.0'
+  VERSION = '2.9.1'
 end

spec/test_spec.rb

@@ -411,6 +411,58 @@ def call(_env)
     end
   end
 
+  describe 'handling invalid requests' do
+    let(:definition) do
+      OpenapiFirst.parse(
+        {
+          'openapi' => '3.1.0',
+          'paths' => {
+            '/stuff/{id}' => {
+              'get' => {
+                'parameters' => [
+                  {
+                    'name' => 'id',
+                    'in' => 'path',
+                    'required' => true,
+                    'schema' => {
+                      'type' => 'integer'
+                    }
+                  }
+                ],
+                'responses' => {
+                  '200' => {
+                    'descrition' => 'Ok'
+                  }
+                }
+              }
+            }
+          }
+        },
+        filepath: 'somefile'
+      )
+    end
+
+    let(:app) do
+      described_class.app(
+        ->(_env) { [200, { 'content-type' => 'application/json' }, ['foo']] },
+        spec: definition
+      )
+    end
+
+    before(:each) do
+      described_class.setup do |test|
+        test.register(definition)
+        test.report_coverage = false
+      end
+    end
+
+    it 'raises no error, but tracks the request' do
+      app.call(Rack::MockRequest.env_for('/stuff/nostring'))
+
+      expect(described_class::Coverage.result.coverage).to eq 50
+    end
+  end
+
   describe 'handling unknown requests paths' do
     let(:app) do
       described_class.app(