2.5.1

Fix skipping skipped responses during coverage tracking

Author: ahx

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 2.5.1
+
+- Fix skipping skipped responses during coverage tracking
+
 ## 2.5.0
 
 ### New feature

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    openapi_first (2.5.0)
+    openapi_first (2.5.1)
       hana (~> 1.3)
       json_schemer (>= 2.1, < 3.0)
       openapi_parameters (>= 0.3.3, < 2.0)

benchmarks/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    openapi_first (2.5.0)
+    openapi_first (2.5.1)
       hana (~> 1.3)
       json_schemer (>= 2.1, < 3.0)
       openapi_parameters (>= 0.3.3, < 2.0)

lib/openapi_first/test/coverage/plan.rb

@@ -38,7 +38,7 @@ def track_request(validated_request)
         end
 
         def track_response(validated_response)
-          index[validated_response.response_definition.key].track(validated_response) if validated_response.known?
+          index[validated_response.response_definition.key]&.track(validated_response) if validated_response.known?
         end
 
         def done?

lib/openapi_first/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenapiFirst
-  VERSION = '2.5.0'
+  VERSION = '2.5.1'
 end

spec/test/coverage/plan_spec.rb

@@ -169,6 +169,25 @@
     expect(plan.tasks[2].status).to eq('4XX')
   end
 
+  it 'ignores unknown responses' do
+    request = Rack::Request.new(Rack::MockRequest.env_for('/stuff/24'))
+    response = Rack::Response.new
+    response.status = 208
+    unknown_response = oad.validate_response(request, response)
+
+    plan.track_response(unknown_response)
+
+    expect(plan.tasks.count(&:finished?)).to eq(0)
+  end
+
+  it 'ignores skipped responses' do
+    plan = described_class.for(oad, skip_response: ->(res) { res.status == '200' })
+
+    plan.track_response(valid_response)
+
+    expect(plan.tasks.count(&:finished?)).to eq(0)
+  end
+
   context 'with skip_response option' do
     let(:plan) do
       skip_response = ->(response) { response.status == '4XX' }