Don't raise UnknownQueryParameterError if request is ignored in testing

Author: ahx

lib/openapi_first/test.rb

@@ -106,9 +106,12 @@ def self.install
       OpenapiFirst.configure do |config|
         @after_request_validation = config.after_request_validation do |validated_request, oad|
           next unless registered?(oad)
-          raise validated_request.error.exception if raise_request_error?(validated_request)
 
-          check_unknown_query_parameters(validated_request)
+          if configuration.raise_request_error?(validated_request)
+            raise validated_request.error.exception if validated_request.unknown?
+
+            check_unknown_query_parameters(validated_request)
+          end
 
           Coverage.track_request(validated_request, oad)
         end
@@ -152,12 +155,6 @@ def unknown_parameters_message(unknown_parameters, validated_request)
         "Unknown query parameter#{s} #{list} for #{validated_request.fullpath}"
       end
 
-      def raise_request_error?(validated_request)
-        return false if validated_request.valid?
-
-        configuration.raise_request_error?(validated_request)
-      end
-
       def many?(array) = array.length > 1
 
       def raise_response_error?(validated_response, rack_request)

lib/openapi_first/test/configuration.rb

@@ -88,7 +88,7 @@ def raise_request_error?(validated_request)
         return false if @ignore_request_error&.call(validated_request)
         return false if ignore_unknown_requests? && validated_request.unknown?
 
-        validated_request.unknown?
+        true
       end
 
       def raise_response_error?(validated_response, rack_request)

spec/test_spec.rb

@@ -694,6 +694,23 @@ def call(_env)
         app.call(Rack::MockRequest.env_for('/unknown?unknown=12'))
       end.to raise_error OpenapiFirst::NotFoundError
     end
+
+    context 'when request is ignored' do
+      before(:each) do
+        described_class.uninstall
+        described_class.setup do |test|
+          test.register(definition)
+          test.report_coverage = false
+          test.ignore_request_error { |req| req.path == '/stuff' }
+        end
+      end
+
+      it 'raises no error' do
+        expect do
+          app.call(Rack::MockRequest.env_for('/stuff?color=red&unknown=12'))
+        end.not_to raise_error
+      end
+    end
   end
 
   describe 'handling invalid responses' do