Skip to content

Commit 9c8aeca

Browse files
committed
Deprecate setting minimum_coverage value.
Use skip_response_coverage, ignored_unknown_status to configure coverage instead.
1 parent 6a81ff7 commit 9c8aeca

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
## 2.10.0
66

7+
- Deprecate setting minimum_coverage value. Use skip_response_coverage, ignored_unknown_status to configure coverage instead.
78
- Update openapi_parameters to make parsing array query parameters more consistent.
89
Now parsing empty array query parameter like `ids=&` or `ids&` both result in an empty array value (`[]`) instead of `nil` or `""`.
910
- Fix Test::Coverage.result returning < 100 even if plan is fully covered

lib/openapi_first/test/configuration.rb

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ def observe(app, api: :default)
2929
@apps[api] = app
3030
end
3131

32-
attr_accessor :coverage_formatter_options, :coverage_formatter, :response_raise_error, :minimum_coverage,
32+
attr_accessor :coverage_formatter_options, :coverage_formatter, :response_raise_error,
3333
:ignore_unknown_requests
34-
attr_reader :registry, :apps, :report_coverage, :ignored_unknown_status
34+
attr_reader :registry, :apps, :report_coverage, :ignored_unknown_status, :minimum_coverage
3535

3636
# Configure report coverage
3737
# @param [Boolean, :warn] value Whether to report coverage or just warn.
@@ -44,6 +44,13 @@ def report_coverage=(value)
4444
@report_coverage = value
4545
end
4646

47+
# @deprecated Use skip_response_coverage, ignored_unknown_status to configure coverage
48+
def minimum_coverage=(value)
49+
warn 'OpenapiFirst::Test::Configuration#minimum_coverage= is deprecated. ' \
50+
'Use skip_response_coverage, ignored_unknown_status to configure coverage instead.'
51+
@minimum_coverage = value
52+
end
53+
4754
def skip_response_coverage(&block)
4855
return @skip_response_coverage unless block_given?
4956

0 commit comments

Comments
 (0)