Update openapi_paramters to make parsing array query parameters more consistent

Now parsing an empty array query parameter like `ids=&` or `ids&` both result in an empty array value (`[]`) instead of `nil` or `""`.

Author: ahx

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Update openapi_paramters to make parsing array query parameters more consistent.
+  Now parsing an empty array query parameter like `ids=&` or `ids&` both result in an empty array value (`[]`) instead of `nil` or `""`.
 - Fix Test::Coverage.result returning < 100 even if plan is fully covered
 
 ## 2.9.3

Gemfile.lock

@@ -4,7 +4,7 @@ PATH
     openapi_first (2.9.3)
       hana (~> 1.3)
       json_schemer (>= 2.1, < 3.0)
-      openapi_parameters (>= 0.5.1, < 2.0)
+      openapi_parameters (>= 0.6.1, < 2.0)
       rack (>= 2.2, < 4.0)
 
 GEM
@@ -137,11 +137,23 @@ GEM
     net-smtp (0.5.1)
       net-protocol
     nio4r (2.7.4)
+    nokogiri (1.18.8-aarch64-linux-gnu)
+      racc (~> 1.4)
+    nokogiri (1.18.8-aarch64-linux-musl)
+      racc (~> 1.4)
+    nokogiri (1.18.8-arm-linux-gnu)
+      racc (~> 1.4)
+    nokogiri (1.18.8-arm-linux-musl)
+      racc (~> 1.4)
     nokogiri (1.18.8-arm64-darwin)
       racc (~> 1.4)
+    nokogiri (1.18.8-x86_64-darwin)
+      racc (~> 1.4)
     nokogiri (1.18.8-x86_64-linux-gnu)
       racc (~> 1.4)
-    openapi_parameters (0.5.1)
+    nokogiri (1.18.8-x86_64-linux-musl)
+      racc (~> 1.4)
+    openapi_parameters (0.6.1)
       rack (>= 2.2)
     parallel (1.27.0)
     parser (3.3.8.0)
@@ -208,7 +220,7 @@ GEM
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.4)
+    rspec-core (3.13.5)
       rspec-support (~> 3.13.0)
     rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
@@ -217,7 +229,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.4)
-    rubocop (1.76.2)
+    rubocop (1.77.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -270,10 +282,14 @@ GEM
     zeitwerk (2.7.3)
 
 PLATFORMS
-  arm64-darwin-21
-  arm64-darwin-22
-  arm64-darwin-23
-  x86_64-linux
+  aarch64-linux-gnu
+  aarch64-linux-musl
+  arm-linux-gnu
+  arm-linux-musl
+  arm64-darwin
+  x86_64-darwin
+  x86_64-linux-gnu
+  x86_64-linux-musl
 
 DEPENDENCIES
   actionpack
@@ -292,4 +308,4 @@ DEPENDENCIES
   sinatra
 
 BUNDLED WITH
-   2.3.10
+   2.6.9

benchmarks/Gemfile.lock

@@ -4,7 +4,7 @@ PATH
     openapi_first (2.9.3)
       hana (~> 1.3)
       json_schemer (>= 2.1, < 3.0)
-      openapi_parameters (>= 0.5.1, < 2.0)
+      openapi_parameters (>= 0.6.1, < 2.0)
       rack (>= 2.2, < 4.0)
 
 GEM
@@ -32,7 +32,7 @@ GEM
     mustermann (3.0.3)
       ruby2_keywords (~> 0.0.1)
     nio4r (2.7.4)
-    openapi_parameters (0.5.1)
+    openapi_parameters (0.6.1)
       rack (>= 2.2)
     openapi_parser (2.2.6)
     optparse (0.6.0)

openapi_first.gemspec

@@ -25,6 +25,6 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'hana', '~> 1.3'
   spec.add_dependency 'json_schemer', '>= 2.1', '< 3.0'
-  spec.add_dependency 'openapi_parameters', '>= 0.5.1', '< 2.0'
+  spec.add_dependency 'openapi_parameters', '>= 0.6.1', '< 2.0'
   spec.add_dependency 'rack', '>= 2.2', '< 4.0'
 end

spec/middlewares/request_validation/query_parameter_validation_spec.rb

@@ -236,9 +236,15 @@
         expect(last_response.status).to eq 400
       end
 
-      it 'returns 400 if non-required array parameter is empty' do
+      it 'passes if non-required array parameter is empty' do
         get '/search?term=Oscar&filter[id]=1&filter[tag]=&filter[other]=things'
-        expect(last_response.status).to eq 400
+        expect(last_response.status).to eq 200
+        expect(last_request.env[OpenapiFirst::REQUEST].parsed_query).to eq(
+          { 'term' => 'Oscar',
+            'filter[tag]' => [],
+            'filter[id]' => 1,
+            'filter[other]' => 'things' }
+        )
       end
 
       it 'passes if query parameters are valid' do