Merge pull request #345 from kaorukobo/override-path

Allow to override path for schema matching with `env[OpenapiFirst::PATH]`

Author: ahx

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Allow to override path for schema matching with `env[OpenapiFirst::PATH]` (https://github.com/ahx/openapi_first/pull/345)
+
 ## 2.6.0
 
 - Middlewares now accept the OAD as a first positional argument instead of `:spec` inside the options hash.

lib/openapi_first.rb

@@ -15,6 +15,10 @@ module OpenapiFirst
 
   # Key in rack to find instance of Request
   REQUEST = 'openapi.request'
+
+  # Key in rack to store the alternate path used for schema matching
+  PATH = 'openapi.path'
+
   FAILURE = :openapi_first_validation_failure
 
   # @return [Configuration]

lib/openapi_first/definition.rb

@@ -45,7 +45,7 @@ def initialize(contents, filepath = nil)
     # @param [Boolean] raise_error Whether to raise an error if validation fails.
     # @return [ValidatedRequest] The validated request object.
     def validate_request(request, raise_error: false)
-      route = @router.match(request.request_method, request.path, content_type: request.content_type)
+      route = @router.match(request.request_method, resolve_path(request), content_type: request.content_type)
       if route.error
         ValidatedRequest.new(request, error: route.error)
       else
@@ -62,7 +62,8 @@ def validate_request(request, raise_error: false)
     # @param raise_error [Boolean] Whethir to raise an error if validation fails.
     # @return [ValidatedResponse] The validated response object.
     def validate_response(rack_request, rack_response, raise_error: false)
-      route = @router.match(rack_request.request_method, rack_request.path, content_type: rack_request.content_type)
+      route = @router.match(rack_request.request_method, resolve_path(rack_request),
+                            content_type: rack_request.content_type)
       return if route.error # Skip response validation for unknown requests
 
       response_match = route.match_response(status: rack_response.status, content_type: rack_response.content_type)
@@ -76,5 +77,11 @@ def validate_response(rack_request, rack_response, raise_error: false)
         raise validated.error.exception(validated) if raise_error && validated.invalid?
       end
     end
+
+    private
+
+    def resolve_path(rack_request)
+      rack_request.env[PATH] || rack_request.path
+    end
   end
 end

spec/definition_spec.rb

@@ -213,6 +213,20 @@ def build_request(path, method: 'GET')
         ).to be_valid
       end
     end
+
+    context 'with an alternate path used for schema matching' do
+      let(:request) do
+        build_request('/prefix/stuff/42').tap do |req|
+          req.env[OpenapiFirst::PATH] = '/stuff/42'
+        end
+      end
+
+      it 'returns a valid request' do
+        validated = definition.validate_request(request)
+        expect(validated).to be_valid
+        expect(validated.parsed_path_parameters).to eq({ 'id' => 42 })
+      end
+    end
   end
 
   describe '#validate_response' do
@@ -296,6 +310,21 @@ def build_request(path, method: 'GET')
         end
       end
     end
+
+    context 'with an alternate path used for schema matching' do
+      let(:request) do
+        build_request('/prefix/stuff/42').tap do |req|
+          req.env[OpenapiFirst::PATH] = '/stuff'
+        end
+      end
+      let(:response) { Rack::Response.new(JSON.generate({ 'id' => 42 }), 200, { 'Content-Type' => 'application/json' }) }
+
+      it 'returns a valid response' do
+        validated = definition.validate_response(request, response)
+        expect(validated).to be_valid
+        expect(validated.parsed_body).to eq({ 'id' => 42 })
+      end
+    end
   end
 
   describe '#routes' do