Move Test::Methods[args] tests into context

Author: ahx

spec/test/methods_spec.rb

@@ -3,81 +3,90 @@
 require 'minitest'
 
 RSpec.describe OpenapiFirst::Test::Methods do
-  it 'can be included' do
-    minitest_class = Class.new(Minitest::Test) do
+  it 'includes PlainHelpers when included' do
+    test_class = Class.new do
       include OpenapiFirst::Test::Methods
     end
-    expect(minitest_class.included_modules).to include(OpenapiFirst::Test::MinitestHelpers)
-
-    other_class = Class.new do
-      include OpenapiFirst::Test::Methods
-    end
-    expect(other_class.included_modules).to include(OpenapiFirst::Test::PlainHelpers)
+    expect(test_class.included_modules).to include(OpenapiFirst::Test::PlainHelpers)
   end
 
-  it 'adds an app method that wraps the app' do
+  it 'raises OpenapiFirst::Error when assertion fails' do
     OpenapiFirst::Test.register('./examples/openapi.yaml')
-    myapp = ->(_env) { Rack::Response.new('hello').finish }
-    minitest_class = Class.new(Minitest::Test) do
-      include OpenapiFirst::Test::Methods[myapp]
+    test_class = Class.new do
+      include OpenapiFirst::Test::Methods
+
+      def last_request = Rack::Request.new(Rack::MockRequest.env_for('/'))
+      def last_response = Rack::Response.new
     end
-    expect(minitest_class.included_modules).to include(OpenapiFirst::Test::MinitestHelpers)
 
-    test_app = minitest_class.new(1).app
-    env = Rack::MockRequest.env_for('/')
-    expect(test_app.call(env)).to eq(Rack::Response.new('hello').finish)
-    expect(env[OpenapiFirst::REQUEST]).to be_valid
+    expect do
+      test_class.new.assert_api_conform(status: 444)
+    end.to raise_error(OpenapiFirst::Error)
   end
 
-  it 'adds an app method that wraps the app for a specific API' do
-    OpenapiFirst::Test.register('./examples/openapi.yaml', as: :v1)
-    myapp = ->(_env) { Rack::Response.new('hello').finish }
-    minitest_class = Class.new(Minitest::Test) do
-      include OpenapiFirst::Test::Methods[myapp, api: :v1]
+  context 'with Minitest' do
+    it 'includes MinitestHelpers when included' do
+      minitest_class = Class.new(Minitest::Test) do
+        include OpenapiFirst::Test::Methods
+      end
+      expect(minitest_class.included_modules).to include(OpenapiFirst::Test::MinitestHelpers)
     end
-    expect(minitest_class.included_modules).to include(OpenapiFirst::Test::MinitestHelpers)
 
-    test_app = minitest_class.new(1).app
-    env = Rack::MockRequest.env_for('/')
-    expect(test_app.call(env)).to eq(Rack::Response.new('hello').finish)
-    expect(env[OpenapiFirst::REQUEST]).to be_valid
-  end
+    it 'raises Minitest::Assertion when assertion fails' do
+      OpenapiFirst::Test.register('./examples/openapi.yaml')
+      minitest_class = Class.new(Minitest::Test) do
+        include OpenapiFirst::Test::Methods
 
-  it 'does not add an app method if app is nil' do
-    OpenapiFirst::Test.register('./examples/openapi.yaml', as: :v1)
-    minitest_class = Class.new(Minitest::Test) do
-      include OpenapiFirst::Test::Methods[api: :v1]
-    end
-    expect(minitest_class.included_modules).to include(OpenapiFirst::Test::MinitestHelpers)
+        def last_request = Rack::Request.new(Rack::MockRequest.env_for('/'))
+        def last_response = Rack::Response.new
+      end
 
-    expect(minitest_class.new(1).respond_to?(:app)).to eq(false)
+      expect do
+        minitest_class.new('hey').assert_api_conform(status: 444)
+      end.to raise_error(Minitest::Assertion)
+    end
   end
 
-  it 'detects wrong response status for Minitest' do
-    OpenapiFirst::Test.register('./examples/openapi.yaml')
-    minitest_class = Class.new(Minitest::Test) do
-      include OpenapiFirst::Test::Methods
+  context 'with [arguments]' do
+    it 'adds an app method that wraps the default API' do
+      OpenapiFirst::Test.register('./examples/openapi.yaml')
+      myapp = ->(_env) { Rack::Response.new('hello').finish }
 
-      def last_request = Rack::Request.new(Rack::MockRequest.env_for('/'))
-      def last_response = Rack::Response.new
+      minitest_class = Class.new(Minitest::Test) do
+        include OpenapiFirst::Test::Methods[myapp]
+      end
+
+      expect(minitest_class.included_modules).to include(OpenapiFirst::Test::MinitestHelpers)
+      test_app = minitest_class.new(1).app
+      env = Rack::MockRequest.env_for('/')
+      expect(test_app.call(env)).to eq(Rack::Response.new('hello').finish)
+      expect(env[OpenapiFirst::REQUEST]).to be_valid
     end
 
-    expect do
-      minitest_class.new('hey').assert_api_conform(status: 444)
-    end.to raise_error(Minitest::Assertion)
-  end
+    it 'adds an app method that wraps the app for a specific API' do
+      OpenapiFirst::Test.register('./examples/openapi.yaml', as: :v1)
+      myapp = ->(_env) { Rack::Response.new('hello').finish }
 
-  it 'detects wrong response status for non Minitest' do
-    OpenapiFirst::Test.register('./examples/openapi.yaml')
-    other_test_class = Class.new do
-      include OpenapiFirst::Test::Methods
+      minitest_class = Class.new(Minitest::Test) do
+        include OpenapiFirst::Test::Methods[myapp, api: :v1]
+      end
 
-      def last_request = Rack::Request.new(Rack::MockRequest.env_for('/'))
-      def last_response = Rack::Response.new
+      expect(minitest_class.included_modules).to include(OpenapiFirst::Test::MinitestHelpers)
+      test_app = minitest_class.new(1).app
+      env = Rack::MockRequest.env_for('/')
+      expect(test_app.call(env)).to eq(Rack::Response.new('hello').finish)
+      expect(env[OpenapiFirst::REQUEST]).to be_valid
     end
 
-    expect do
-      other_test_class.new.assert_api_conform(status: 444)
-    end.to raise_error(OpenapiFirst::Error)
+    it 'does not add an app method if app is nil' do
+      OpenapiFirst::Test.register('./examples/openapi.yaml', as: :v1)
+
+      minitest_class = Class.new(Minitest::Test) do
+        include OpenapiFirst::Test::Methods[api: :v1]
+      end
+
+      expect(minitest_class.included_modules).to include(OpenapiFirst::Test::MinitestHelpers)
+      expect(minitest_class.new(1).respond_to?(:app)).to eq(false)
+    end
   end
 end