Dont' observe requests/responses to OADs that have not been registered

Author: ahx

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 #### Changed
 - Test now raises a `OpenapiFirst::Test::UnknownQueryParameterError` when it sees unknown query parameters
+- Test does not track requests/responses unless the OAD was registered via Test.register (or OpenapiFirst.register)
 
 ## 3.0.1
 - Add missing gem dependency "drb", which is no longer installed by default with newer rubies. This is used in openapi_first/test to make parallel tests work.

lib/openapi_first/test.rb

@@ -105,6 +105,7 @@ def self.install
 
       OpenapiFirst.configure do |config|
         @after_request_validation = config.after_request_validation do |validated_request, oad|
+          next unless registered?(oad)
           raise validated_request.error.exception if raise_request_error?(validated_request)
 
           check_unknown_query_parameters(validated_request)
@@ -113,6 +114,7 @@ def self.install
         end
 
         @after_response_validation = config.after_response_validation do |validated_response, rack_request, oad|
+          next unless registered?(oad)
           if validated_response.invalid? && raise_response_error?(validated_response)
             raise validated_response.error.exception
           end

spec/test_spec.rb

@@ -485,6 +485,19 @@ def call(_env)
 
       expect(described_class::Coverage.result.coverage).to eq 50
     end
+
+    it 'tracks the request' do
+      expect(described_class::Coverage).to receive(:track_request)
+
+      app.call(Rack::MockRequest.env_for('/stuff/nostring'))
+    end
+
+    it 'does not track the request for for unregistered OADs' do
+      expect(described_class).to receive(:registered?).twice.and_return(false) # once for request, once for response tracking
+      expect(described_class::Coverage).not_to receive(:track_request)
+
+      app.call(Rack::MockRequest.env_for('/stuff/1'))
+    end
   end
 
   describe 'handling unknown requests paths' do
@@ -712,4 +725,52 @@ def call(_env)
       end
     end
   end
+
+  describe 'handling valid responses' do
+    let(:definition) do
+      OpenapiFirst.parse(YAML.load(%(
+        openapi: 3.1.0
+        info:
+          title: Dice
+          version: 1
+        paths:
+          "/roll":
+            post:
+              responses:
+                '200':
+                  content:
+                    application/json:
+                      schema:
+                        type: integer
+                        min: 1
+                        max:
+      )))
+    end
+
+    let(:app) do
+      described_class.app(
+        ->(_env) { [200, { 'content-type' => 'application/json' }, ['1']] },
+        spec: definition
+      )
+    end
+
+    before(:each) do
+      described_class.setup do |test|
+        test.register(definition)
+      end
+    end
+
+    it 'tracks the response' do
+      expect(described_class::Coverage).to receive(:track_response)
+
+      app.call(Rack::MockRequest.env_for('/roll', method: 'POST'))
+    end
+
+    it 'does not track the response for for unregistered OADs' do
+      expect(described_class).to receive(:registered?).twice.and_return(false) # once for request, once for response tracking
+      expect(described_class::Coverage).not_to receive(:track_response)
+
+      app.call(Rack::MockRequest.env_for('/roll', method: 'POST'))
+    end
+  end
 end