Skip to content

Commit f79b0b3

Browse files
committed
No need to deprecate minimum_coverage=
1 parent 7daefb3 commit f79b0b3

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ OpenapiFirst::Test is stricter and more configurable:
88
- Added Test::Configuration#ignored_unknown_status` to configure response status(es) that do not have to be descriped in the API description.
99
- Changed `OpenapiFirst::Test` to make tests fail if API description is not covered by tests. You can adapt this behavior via `OpenapiFirst::Test.setup` / `skip_response_coverage` or deactivate coverage with `report_coverage = false` or `report_coverage = :warn`
1010
- Added `OpenapiFirst::Test::Configuration#report_coverage=` to configure the behavior if not all requests/responses of the API under test have been tested.
11-
- Deprecated `OpenapiFirst::Test::Configuration#minimum_coverage=` use "#report_coverage=true/false/:info" instead to modify the behavior
1211
- Changed OpenapiFirst::Test to raises an "invalid response" error if it sees an invalid response (https://github.com/ahx/openapi_first/issues/366).
1312
You can change this back to the old behavior by setting `response_raise_error = false` (but you shouldn't).
1413

lib/openapi_first/test/configuration.rb

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,8 @@ def observe(app, api: :default)
2828
@apps[api] = app
2929
end
3030

31-
attr_accessor :coverage_formatter_options, :coverage_formatter, :response_raise_error
32-
attr_reader :registry, :apps, :minimum_coverage, :report_coverage, :ignored_unknown_status
33-
34-
def minimum_coverage=(value)
35-
warn 'Setting OpenapiFirst::Test::Configuration#minimum_coverage= is deprecated ' \
36-
'and will be removed in a future version.' \
37-
"Use 'report_coverage = true / false / :info' instead."
38-
@minimum_coverage = value
39-
end
31+
attr_accessor :coverage_formatter_options, :coverage_formatter, :response_raise_error, :minimum_coverage
32+
attr_reader :registry, :apps, :report_coverage, :ignored_unknown_status
4033

4134
# Configure report coverage
4235
# @param [Boolean, :warn] value Whether to report coverage or just warn.

0 commit comments

Comments
 (0)