refactor(components): standardize approval selects and decision handling#15
Merged
Conversation
Create decision constant and refactor tests
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Refine the component approval flows to use consistent selection controls and simplify how approval decisions move through the chat UI.
What is the current behavior?
Approval-related components use mixed interaction patterns, and tool approval passes separate approve/reject callbacks instead of a single shared decision value.
What is the new behavior?
Tool approval now uses , approval decisions flow through a shared constant/type, and the related component tests were updated to match the new interaction model while keeping coverage at 100%.
Checklist: