Skip to content

test(ModelPicker): fix failing tests#49

Merged
remarkablemark merged 2 commits into
masterfrom
test/ModelPicker
May 10, 2026
Merged

test(ModelPicker): fix failing tests#49
remarkablemark merged 2 commits into
masterfrom
test/ModelPicker

Conversation

@remarkablemark
Copy link
Copy Markdown
Member

@remarkablemark remarkablemark commented May 10, 2026

What is the motivation for this pull request?

Fix failing tests in CI for ModelPicker component:

 FAIL  src/components/ModelPicker.test.tsx > ModelPicker > calls onClose on Escape
AssertionError: expected "vi.fn()" to be called at least once
 ❯ src/components/ModelPicker.test.tsx:174:21
    172|     stdin.write(KEY.ESCAPE);
    173|     await time.tick(20);
    174|     expect(onClose).toHaveBeenCalled();
       |                     ^
    175|   });
    176|

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯

 FAIL  src/components/ModelPicker.test.tsx > ModelPicker > calls onClose on Enter after models load
AssertionError: expected "vi.fn()" to be called 1 times, but got 0 times
 ❯ src/components/ModelPicker.test.tsx:210:21
    208|     await time.tick(10);
    209|
    210|     expect(onClose).toHaveBeenCalledTimes(1);
       |                     ^
    211|   });
    212|

Checklist:

@remarkablemark remarkablemark changed the title test(ModelPicker): fix keyboard event handling in mock Select test(ModelPicker): fix failing tests May 10, 2026
@remarkablemark remarkablemark self-assigned this May 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/components/ModelPicker.tsx 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remarkablemark remarkablemark changed the title test(ModelPicker): fix failing tests fix(ModelPicker): fix tests and OOM error May 10, 2026
@remarkablemark remarkablemark changed the title fix(ModelPicker): fix tests and OOM error fix(ModelPicker): fix tests and OOM error when loading models May 10, 2026
Comment thread src/utils/ollama.ts Fixed
@remarkablemark remarkablemark added the bug Something isn't working label May 10, 2026
@remarkablemark remarkablemark changed the title fix(ModelPicker): fix tests and OOM error when loading models fix(ModelPicker): fix tests May 10, 2026
@remarkablemark remarkablemark removed the bug Something isn't working label May 10, 2026
@remarkablemark remarkablemark changed the title fix(ModelPicker): fix tests test(ModelPicker): fix tests May 10, 2026
@remarkablemark remarkablemark changed the title test(ModelPicker): fix tests test(ModelPicker): fix failing tests May 10, 2026
@remarkablemark remarkablemark merged commit df65329 into master May 10, 2026
15 checks passed
@remarkablemark remarkablemark deleted the test/ModelPicker branch May 10, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants