Skip to content

Commit 158c07e

Browse files
Chisanan232claude
andcommitted
♻️ (scripts): Extract _align_prereq_readme to cut complexity
process_prereq_rows nested two rewrite loops and a touched flag inside its per-README loop, pushing cognitive complexity to 16 (python:S3776, limit 15). Move the per-README alignment into _align_prereq_readme, leaving the outer function a flat collect loop. Behaviour identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TdxntF32Wi278LGD22dVS4
1 parent c2462e3 commit 158c07e

1 file changed

Lines changed: 20 additions & 10 deletions

File tree

scripts/generate_example_metadata.py

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -869,6 +869,25 @@ def _prereq_readmes(repo_root: Path) -> list[Path]:
869869
return out
870870

871871

872+
def _align_prereq_readme(
873+
readme: Path,
874+
labels: tuple[tuple[str, str], ...],
875+
backtick_packages: tuple[tuple[str, str], ...],
876+
) -> bool:
877+
"""Align every prereq row/bullet in one README; return True if any changed."""
878+
879+
touched = False
880+
for label, version in labels:
881+
if rewrite_prereq_row(readme, label, version):
882+
touched = True
883+
if rewrite_prereq_bullet(readme, label, version):
884+
touched = True
885+
for package, version in backtick_packages:
886+
if rewrite_prereq_backtick_row(readme, package, version):
887+
touched = True
888+
return touched
889+
890+
872891
def process_prereq_rows(repo_root: Path, versions: SdkVersions) -> list[Path]:
873892
"""Align every hand-written ``Agent Assembly <Lang> SDK`` prereq row.
874893
@@ -891,16 +910,7 @@ def process_prereq_rows(repo_root: Path, versions: SdkVersions) -> list[Path]:
891910
)
892911
changed: list[Path] = []
893912
for readme in _prereq_readmes(repo_root):
894-
touched = False
895-
for label, version in labels:
896-
if rewrite_prereq_row(readme, label, version):
897-
touched = True
898-
if rewrite_prereq_bullet(readme, label, version):
899-
touched = True
900-
for package, version in backtick_packages:
901-
if rewrite_prereq_backtick_row(readme, package, version):
902-
touched = True
903-
if touched:
913+
if _align_prereq_readme(readme, labels, backtick_packages):
904914
changed.append(readme)
905915
return changed
906916

0 commit comments

Comments
 (0)