Skip to content

[AAASM-4771] 📝 (ci): Correct stale gateway-image comment on live scenario job#324

Merged
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4771/fix_live_job_comment
Jul 17, 2026
Merged

[AAASM-4771] 📝 (ci): Correct stale gateway-image comment on live scenario job#324
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4771/fix_live_job_comment

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

What changed

Corrected the stale comment on the live-core-enforcement-live job in
.github/workflows/verify-scenarios.yml. The comment told operators to
trigger the job "when a gateway image is available," but
ghcr.io/ai-agent-assembly/aa-gateway is now published (tagged
v0.0.1-rc.4/rc.5/rc.6/latest, confirmed on GHCR) — image availability
was already fixed as the stale claim in the scenario README (AAASM-4743), and
this is the companion fix for the CI workflow comment. The job remains
workflow_dispatch-only: verify-live.yml already runs this same scenario's
live drivers (scenarios/live-core-enforcement/{python,node,go}-agent) on a
daily schedule via the lighter aasm start --mode local path, so standing up
the full 3-container docker-compose stack here too on a schedule/PR would be
redundant CI weight with no additional signal. No job trigger conditions
changed — comment-only fix.

Related ticket

Closes AAASM-4771

https://lightning-dust-mite.atlassian.net/browse/AAASM-4771

Fixes AAASM-4771

How to verify

  • python -c "import yaml; yaml.safe_load(open('.github/workflows/verify-scenarios.yml'))" parses cleanly.
  • Diff is comment-only; no job if:/trigger conditions were changed, so no CI behavior changes.

Checklist

  • PR title follows [AAASM-XXXX] <GitEmoji> (<scope>): <summary>
  • No secrets, API keys, or .env files committed
  • Example sub-projects include their own README.md with prerequisites and run instructions (unchanged by this PR)
  • SDK/runtime version dependencies are documented or pinned (unchanged by this PR)

The live-core-enforcement-live job's comment said to trigger it "when a
gateway image is available" — ghcr.io/ai-agent-assembly/aa-gateway is now
published (rc.4/rc.5/rc.6/latest), so image availability is no longer the
blocker. Companion to AAASM-4743, which corrected the same stale claim in
the scenario README. Job stays workflow_dispatch-only since verify-live.yml
already covers this scenario's live drivers on a daily schedule via the
lighter `aasm start --mode local` path.

Refs AAASM-4771
@sonarqubecloud

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

Claude Code — automated review

CI: All green (full scenario matrix); YAML parses.
Scope (AAASM-4771): corrected the stale "gateway image not published" comment on the live-core-enforcement-live job. Job kept workflow_dispatch-only — sound call: verify-live.yml already exercises this scenario on a daily schedule via the lighter local-mode path, so enabling the heavy 3-container compose lane too would be redundant CI weight.
Side effects: none — comment-only.
Verdict: ✅ Ready to merge. (Same stale claim also noted in docker-compose.yml + verify-live.yml headers — optional broader follow-up.)

@Chisanan232

Copy link
Copy Markdown
Contributor Author

Claude Code — review result (final pass)

CI: all checks green. Scope: matches the ticket. Side effects: none — green full-suite CI validates no existing-function/business-logic breakage. Front-End: no FE/dashboard code touched, so no Playwright validation applies. Verdict: ✅ ready to approve & merge.

Review comments: SonarCloud Quality Gate passed (informational) — no actionable threads.

@Chisanan232
Chisanan232 merged commit 9fcd51f into master Jul 17, 2026
25 checks passed
@Chisanan232
Chisanan232 deleted the v0.0.1/AAASM-4771/fix_live_job_comment branch July 17, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant