[AAASM-4795] 🐛 (examples): Fix wrong gateway image name + add pnpm onlyBuiltDependencies#331
Merged
Merged
Conversation
The 'switch to real gateway' comment referenced ghcr.io/ai-agent-assembly/agent-assembly-gateway, an image that never existed — every other in-repo reference uses aa-gateway, so following this comment produced 'manifest unknown' on docker compose up.
The 6 node/* framework examples (langchain-js-basic-agent, langgraph-js, mastra, vercel-ai, openai-node-tool-policy, custom-tool-policy) had no pnpm.onlyBuiltDependencies allowlist, so pnpm install hard-fails under pnpm v11+ with ERR_PNPM_IGNORED_BUILDS (CI's pinned pnpm v10 only warns). @agent-assembly/sdk and protobufjs (a transitive dep of @grpc/proto-loader, pulled in by the SDK) both ship a postinstall script, and esbuild (via vitest/vite) needs its binary download allowed — matching the allowlist already carried by scenarios/policy-enforcement and scenarios/approval-gates' node projects.
|
Contributor
Author
Claude Code — automated reviewCI: green. Scope: matches the ticket. Side effects: none — green full-suite CI (incl. build/lint/impacted tests) validates no existing-function breakage. Front-End: no FE/dashboard code touched → no Playwright validation applies. Verdict: ✅ ready to approve & merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two low-severity onboarding fixes:
scenarios/sidecar-runtime/docker-compose.yml— the "switch to real gateway"comment pointed at
ghcr.io/ai-agent-assembly/agent-assembly-gateway:latest,an image that never existed (every other in-repo reference uses
aa-gateway). Following the comment producedmanifest unknownondocker compose up. Fixed toghcr.io/ai-agent-assembly/aa-gateway:latest.node/*framework examples (langchain-js-basic-agent,langgraph-js,mastra,vercel-ai,openai-node-tool-policy,custom-tool-policy) had nopnpm.onlyBuiltDependenciesallowlist, sopnpm installhard-fails under pnpm v11+ withERR_PNPM_IGNORED_BUILDS(CI's pinned pnpm v10 only warns, masking the issue). Added
"onlyBuiltDependencies": ["@agent-assembly/sdk", "esbuild", "protobufjs"]to each — matching the allowlist already carried by
scenarios/policy-enforcementandscenarios/approval-gates's nodeprojects. Confirmed via each example's
pnpm-lock.yamlthat@agent-assembly/sdk(ownpostinstallscript) andprotobufjs(atransitive dep of
@grpc/proto-loader, itself pulled in by the SDK; alsoships a
postinstallscript) are present in every one of the 6, alongsideesbuild(via vitest/vite) which the reference examples already allowlist.Related ticket
Closes AAASM-4795
https://lightning-dust-mite.atlassian.net/browse/AAASM-4795
Fixes AAASM-4795
How to verify
python3 -c "import yaml; yaml.safe_load(open('scenarios/sidecar-runtime/docker-compose.yml'))"— parses cleanly.python3 -c "import json; json.load(open(...))"on each of the 6 touchedpackage.jsonfiles — all valid JSON.python3 scripts/generate_example_metadata.py --check— passes, no drift introduced (this generator audits SDK-version pins only; it does not cover compose image names or pnpm build allowlists, so it does not directly assert on either fix, but confirms no side effects).pnpm installacross all examples.Checklist
[AAASM-XXXX] <GitEmoji> (<scope>): <summary>.envfiles committedREADME.mdwith prerequisites and run instructions (unchanged by this PR)