[AAASM-4826] 📝 (examples): Replace fabricated SDK symbols in real-integration guidance#334
Merged
Merged
Conversation
The "real integration" stub guidance imported non-existent symbols
(AssemblyClient, BudgetPolicy) from the SDKs. Budget ceilings are a
gateway-side per-team policy, not a client-side class — correct the
guidance to init_assembly + ctx.client.dispatch_tool (python) and
withAssembly(tools, {gatewayClient, agentId}) (node). Runnable offline
stubs unchanged.
Refs AAASM-4826
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The "real integration" stub guidance imported non-existent symbols
(AssemblyClient, AuditLogger) from the SDKs. Audit events are recorded
gateway-side, not via a client-side logger class — correct the guidance
to init_assembly + ctx.client.dispatch_tool (python) and
withAssembly(tools, {gatewayClient, agentId}) (node). Runnable offline
stubs unchanged.
Refs AAASM-4826
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The AAASM-4807 fix corrected the sidecar node agent but missed this python docstring, which still taught the non-existent ctx.client.call_tool(name, path=...). The real client method is the async ctx.client.dispatch_tool(name, args_dict). Correct the diagram, the "real project" block, and the shim comment; runnable stub unchanged. Refs AAASM-4826 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Contributor
Author
🤖 Claude Code — PR reviewScope (AAASM-4826, MED — fabricated APIs): ✅ replaced non-existent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
The "real integration" / "replace these with" stub guidance in five scenario
agents imported SDK symbols that do not exist.
AssemblyClient,BudgetPolicy,and
AuditLoggerare not exported by either the Python (agent-assembly) orNode (
@agent-assembly/sdk) SDK, and the sidecar-runtime python agent stilltaught
ctx.client.call_tool(name, path=...)(a method AAASM-4807 alreadycorrected in the README and node agent, but missed here).
This corrects the guidance to the actual published SDK surface, verified against
the sibling
python-sdk/node-sdkcheckouts:from agent_assembly import init_assembly; governed calls viathe async
ctx.client.dispatch_tool(name, args_dict)or the framework runtimeinterceptor.
dispatch_tool/init_assemblyconfirmed present.withAssembly(tools, { gatewayClient, agentId }), which throwsPolicyViolationErroron deny.withAssembly/initAssembly/PolicyViolationErrorconfirmed exported.is a per-team policy (mirrored by each scenario's
policy.yaml) and auditevents are recorded gateway-side, neither is a fabricated client-side class.
Each scenario's runnable offline stub is left untouched and self-consistent;
only the "make this real" guidance comments/docstrings changed.
Related ticket
Closes AAASM-4826
Jira: https://lightning-dust-mite.atlassian.net/browse/AAASM-4826
How to verify
node --checkon both nodeagent.js— pass.python -m py_compileon all three pythonagent.py— pass.python … agent.py,node … agent.js).AssemblyClient/BudgetPolicy/AuditLoggerexport exists.Checklist
[AAASM-XXXX] <GitEmoji> (<scope>): <summary>.envfiles committedREADME.mdwith prerequisites and run instructions🤖 Generated with Claude Code