Skip to content

[AAASM-4826] 📝 (examples): Replace fabricated SDK symbols in real-integration guidance#334

Merged
Chisanan232 merged 3 commits into
masterfrom
v0.0.1/AAASM-4826/fabricated_sdk_apis
Jul 18, 2026
Merged

[AAASM-4826] 📝 (examples): Replace fabricated SDK symbols in real-integration guidance#334
Chisanan232 merged 3 commits into
masterfrom
v0.0.1/AAASM-4826/fabricated_sdk_apis

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

What changed

The "real integration" / "replace these with" stub guidance in five scenario
agents imported SDK symbols that do not exist. AssemblyClient, BudgetPolicy,
and AuditLogger are not exported by either the Python (agent-assembly) or
Node (@agent-assembly/sdk) SDK, and the sidecar-runtime python agent still
taught ctx.client.call_tool(name, path=...) (a method AAASM-4807 already
corrected in the README and node agent, but missed here).

This corrects the guidance to the actual published SDK surface, verified against
the sibling python-sdk/node-sdk checkouts:

  • Pythonfrom agent_assembly import init_assembly; governed calls via
    the async ctx.client.dispatch_tool(name, args_dict) or the framework runtime
    interceptor. dispatch_tool / init_assembly confirmed present.
  • NodewithAssembly(tools, { gatewayClient, agentId }), which throws
    PolicyViolationError on deny. withAssembly / initAssembly /
    PolicyViolationError confirmed exported.
  • Budget & audit — clarified as gateway-side concerns: a budget ceiling
    is a per-team policy (mirrored by each scenario's policy.yaml) and audit
    events are recorded gateway-side, neither is a fabricated client-side class.

Each scenario's runnable offline stub is left untouched and self-consistent;
only the "make this real" guidance comments/docstrings changed.

Related ticket

Closes AAASM-4826

Jira: https://lightning-dust-mite.atlassian.net/browse/AAASM-4826

How to verify

  • node --check on both node agent.js — pass.
  • python -m py_compile on all three python agent.py — pass.
  • All five agents still run offline (python … agent.py, node … agent.js).
  • Every referenced real symbol grep-confirmed in the SDK sources; no
    AssemblyClient/BudgetPolicy/AuditLogger export exists.

Checklist

  • PR title follows [AAASM-XXXX] <GitEmoji> (<scope>): <summary>
  • No secrets, API keys, or .env files committed
  • Example sub-projects include their own README.md with prerequisites and run instructions
  • SDK/runtime version dependencies are documented or pinned

🤖 Generated with Claude Code

Chisanan232 and others added 3 commits July 18, 2026 08:49
The "real integration" stub guidance imported non-existent symbols
(AssemblyClient, BudgetPolicy) from the SDKs. Budget ceilings are a
gateway-side per-team policy, not a client-side class — correct the
guidance to init_assembly + ctx.client.dispatch_tool (python) and
withAssembly(tools, {gatewayClient, agentId}) (node). Runnable offline
stubs unchanged.

Refs AAASM-4826

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The "real integration" stub guidance imported non-existent symbols
(AssemblyClient, AuditLogger) from the SDKs. Audit events are recorded
gateway-side, not via a client-side logger class — correct the guidance
to init_assembly + ctx.client.dispatch_tool (python) and
withAssembly(tools, {gatewayClient, agentId}) (node). Runnable offline
stubs unchanged.

Refs AAASM-4826

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The AAASM-4807 fix corrected the sidecar node agent but missed this
python docstring, which still taught the non-existent
ctx.client.call_tool(name, path=...). The real client method is the
async ctx.client.dispatch_tool(name, args_dict). Correct the diagram,
the "real project" block, and the shim comment; runnable stub unchanged.

Refs AAASM-4826

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

🤖 Claude Code — PR review

Scope (AAASM-4826, MED — fabricated APIs): ✅ replaced non-existent AssemblyClient/BudgetPolicy/AuditLogger (budget-limits + audit-trace, both langs) with real init_assembly().client.dispatch_tool / withAssembly; fixed the sidecar python call_tool the 4807 fix missed; clarified budget/audit are gateway-side.

  1. CI — ✅ green (23). 2. Scope — ✅ 5 stub files; runnable offline stubs untouched; every symbol grep-verified. 3. Side effects — none. 4. FE — n/a.
    Verdict: ready to merge pending Pioneer approval.

@Chisanan232
Chisanan232 merged commit 692afe3 into master Jul 18, 2026
24 checks passed
@Chisanan232
Chisanan232 deleted the v0.0.1/AAASM-4826/fabricated_sdk_apis branch July 18, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant