[AAASM-4838] 📝 (examples): Make crewai/langchain-research live-mode honest (was inert)#339
Merged
Merged
Conversation
The computed `mock` flag was never branched on, so a non-mock run replayed the scripted trajectory while labelling the mode "live". Gate the live path: refuse it with a clear "not implemented" notice and drop the dead flag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the "Switching to the live CrewAI integration" runnable steps with an honest note that this is an offline scripted demo and no live mode is shipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…eplay The `mock` flag only fed a print label; a non-mock run replayed the scripted ReAct trajectory mislabelled "live". Gate the live path: refuse it with a clear "not implemented" notice and drop the dead flag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ions Replace the "Switching to production mode" runnable steps with an honest note that this is an offline scripted demo and no live mode is shipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Contributor
Author
🤖 Claude Code — PR reviewScope (AAASM-4838, MED): ✅ crewai/langchain-research 'live mode' now refuses cleanly with a clear notice instead of silently replaying the mock under a 'live' label;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
Both
python/crewai-research-crewandpython/langchain-research-agentcomputeda
mockflag but never branched on it: every invocation replayed the staticscripted trajectory, while a non-mock run mislabelled the mode as "live". The
READMEs' "Switching to the live … integration" / "Switching to production mode"
sections handed users a
uv run python src/main.pycommand that produced theexact same scripted output — an inert "live mode" that promised a real
crew/agent loop the code never runs.
A real CrewAI crew / LangChain ReAct loop is out of scope for this example
gallery (offline, no LLM keys, CI-safe). So the fix makes the guidance honest
rather than faking a live path:
mockflag: a non-mock invocation (withOPENAI_API_KEYset) now prints a clear "live integration is not implementedin this example — it is an offline scripted governance demo" notice and exits,
instead of replaying the mock under a "live" label. The dead computed flag is
removed; the mode label is now always
mock (offline).state plainly that these are offline scripted demos with no runnable live mode,
and describe a real integration only as a conceptual, out-of-scope exercise —
no command that the code doesn't actually run.
The offline
--mockpath (what CI exercises) is unchanged.Related ticket
Closes AAASM-4838
Jira: https://lightning-dust-mite.atlassian.net/browse/AAASM-4838
How to verify
Checklist
[AAASM-XXXX] <GitEmoji> (<scope>): <summary>.envfiles committedREADME.mdwith prerequisites and run instructions🤖 Generated with Claude Code