Skip to content

Commit 1b14761

Browse files
committed
ci(checkpoint): gate TRTLLM DynamoCheckpoint tests on snapshot changes only
Follow the vLLM/SGLang pattern from #11046 (ci: gate DynamoCheckpoint deploy tests on snapshot changes only): narrow the changed-files gate on every TRTLLM checkpoint job (snapshot-placeholder, operator setup, snapshot-agent, deploy-test, cleanup) from (operator || snapshot || deploy) to (snapshot == 'true'). Also drop the redundant operator.result == 'skipped' branch so the operator-setup gate matches vLLM/SGLang. The snapshot path filter (.github/filters.yaml) already covers tests/deploy/test_dynamocheckpoint.py, so TRTLLM test changes still trigger these jobs. post-merge-ci.yml already gates all three frameworks identically and needs no change. Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
1 parent 4c19dd8 commit 1b14761

1 file changed

Lines changed: 6 additions & 16 deletions

File tree

.github/workflows/pr.yaml

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -870,9 +870,7 @@ jobs:
870870
needs: [changed-files, trtllm-copy-to-acr]
871871
if: |
872872
always() && !cancelled() &&
873-
(needs.changed-files.outputs.operator == 'true' ||
874-
needs.changed-files.outputs.snapshot == 'true' ||
875-
needs.changed-files.outputs.deploy == 'true')
873+
(needs.changed-files.outputs.snapshot == 'true')
876874
runs-on: prod-default-v2
877875
steps:
878876
- name: Checkout code
@@ -1042,10 +1040,8 @@ jobs:
10421040
name: TRTLLM DynamoCheckpoint Operator Setup
10431041
if: |
10441042
always() && !cancelled() &&
1045-
(needs.changed-files.outputs.operator == 'true' ||
1046-
needs.changed-files.outputs.snapshot == 'true' ||
1047-
needs.changed-files.outputs.deploy == 'true') &&
1048-
(needs.operator.result == 'success' || needs.operator.result == 'skipped')
1043+
(needs.changed-files.outputs.snapshot == 'true') &&
1044+
needs.operator.result == 'success'
10491045
needs: [changed-files, operator]
10501046
runs-on: prod-deploy-tester-v1
10511047
permissions:
@@ -1169,9 +1165,7 @@ jobs:
11691165
needs: [changed-files, deploy-operator-checkpoint-trtllm, snapshot-agent]
11701166
if: |
11711167
always() && !cancelled() &&
1172-
(needs.changed-files.outputs.operator == 'true' ||
1173-
needs.changed-files.outputs.snapshot == 'true' ||
1174-
needs.changed-files.outputs.deploy == 'true') &&
1168+
(needs.changed-files.outputs.snapshot == 'true') &&
11751169
needs.deploy-operator-checkpoint-trtllm.result == 'success' &&
11761170
needs.snapshot-agent.result == 'success'
11771171
runs-on: prod-deploy-tester-v1
@@ -1348,9 +1342,7 @@ jobs:
13481342
needs: [changed-files, deploy-operator-checkpoint-trtllm, deploy-snapshot-agent-checkpoint-trtllm, snapshot-placeholder-trtllm, frontend-copy-to-acr]
13491343
if: |
13501344
always() && !cancelled() &&
1351-
(needs.changed-files.outputs.operator == 'true' ||
1352-
needs.changed-files.outputs.snapshot == 'true' ||
1353-
needs.changed-files.outputs.deploy == 'true') &&
1345+
(needs.changed-files.outputs.snapshot == 'true') &&
13541346
needs.deploy-snapshot-agent-checkpoint-trtllm.result == 'success' &&
13551347
needs.snapshot-placeholder-trtllm.result == 'success' &&
13561348
needs.frontend-copy-to-acr.result == 'success'
@@ -1459,9 +1451,7 @@ jobs:
14591451
name: TRTLLM DynamoCheckpoint Cleanup
14601452
if: |
14611453
always() &&
1462-
(needs.changed-files.outputs.operator == 'true' ||
1463-
needs.changed-files.outputs.snapshot == 'true' ||
1464-
needs.changed-files.outputs.deploy == 'true')
1454+
(needs.changed-files.outputs.snapshot == 'true')
14651455
needs: [changed-files, deploy-operator-checkpoint-trtllm, deploy-snapshot-agent-checkpoint-trtllm, deploy-test-checkpoint-trtllm]
14661456
runs-on: prod-deploy-tester-v1
14671457
steps:

0 commit comments

Comments
 (0)