Skip to content

feat(runtime): add Bulwark failover replay support#10470

Merged
hutm merged 0 commit into
review/gms-v2-latehost-05-trtllm-v2-integrationfrom
review/gms-v2-latehost-06-runtime-failover-replay
Jun 29, 2026
Merged

feat(runtime): add Bulwark failover replay support#10470
hutm merged 0 commit into
review/gms-v2-latehost-05-trtllm-v2-integrationfrom
review/gms-v2-latehost-06-runtime-failover-replay

Conversation

@hutm

@hutm hutm commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Stacked PR in the GMS-managed KV review train.

Base: review/gms-v2-latehost-05-trtllm-v2-integration
Head: review/gms-v2-latehost-06-runtime-failover-replay

Refs #10454 #10450

This PR is intentionally scoped to one commit in the train so reviewers can inspect the GMS KV ownership, engine integration, Bulwark, host-tier, router, and docs work incrementally.

@hutm hutm requested review from a team as code owners June 9, 2026 05:07
@copy-pr-bot

copy-pr-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added documentation Improvements or additions to documentation frontend `python -m dynamo.frontend` and `dynamo-run in=http|text|grpc` labels Jun 9, 2026
@hutm hutm force-pushed the review/gms-v2-latehost-05-trtllm-v2-integration branch from 25e9868 to 6a18746 Compare June 9, 2026 07:04
@hutm hutm changed the title runtime: add Bulwark failover replay support feat(runtime): add Bulwark failover replay support Jun 9, 2026
@hutm hutm force-pushed the review/gms-v2-latehost-06-runtime-failover-replay branch from 9ebf0dc to 3c6281d Compare June 9, 2026 07:10
@github-actions github-actions Bot added the feat label Jun 9, 2026
@hutm hutm force-pushed the review/gms-v2-latehost-06-runtime-failover-replay branch from 3c6281d to 1870b0c Compare June 9, 2026 07:16
Comment thread lib/llm/src/migration.rs Outdated
Comment thread lib/llm/src/migration.rs
@hutm hutm force-pushed the review/gms-v2-latehost-06-runtime-failover-replay branch 4 times, most recently from 7887e37 to 0074685 Compare June 9, 2026 07:48
Comment thread lib/llm/src/migration.rs
Some(output) => output,
None => return,
};
self.current_stream_has_output = true;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A non-migratable error frame with no data leaves current_stream_has_output false, so the following EOF is treated as an empty stream and can replay the request after already sending an error to the client. Fix: mark the current stream as having emitted a response frame before returning from track_response for data == None, or add a separate response-frame flag and use it for the empty-stream retry check.

🤖 AI Fix

In lib/llm/src/migration.rs, update RetryManager::track_response so it sets self.current_stream_has_output = true before matching response.data.as_ref(), ensuring error/annotation frames prevent the later empty-stream replay path from recreating the request after a frame was already returned.

@hutm hutm force-pushed the review/gms-v2-latehost-05-trtllm-v2-integration branch from 6a18746 to 49cdf84 Compare June 9, 2026 15:26
@hutm hutm force-pushed the review/gms-v2-latehost-06-runtime-failover-replay branch 2 times, most recently from caa8c35 to ed66524 Compare June 9, 2026 15:45
@hutm hutm closed this Jun 29, 2026
@hutm hutm force-pushed the review/gms-v2-latehost-06-runtime-failover-replay branch from ed66524 to 3d7d0b3 Compare June 29, 2026 17:30
@hutm hutm merged commit 3d7d0b3 into review/gms-v2-latehost-05-trtllm-v2-integration Jun 29, 2026
@hutm hutm force-pushed the review/gms-v2-latehost-05-trtllm-v2-integration branch from 49cdf84 to 0decb04 Compare June 29, 2026 17:30
@hutm hutm deleted the review/gms-v2-latehost-06-runtime-failover-replay branch June 29, 2026 17:30
@hutm

hutm commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Historical review record preserved. GitHub cannot retarget this merged stacked PR; its current replacement is #11049 (position 1/18). No historical comments or reviews are being deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feat frontend `python -m dynamo.frontend` and `dynamo-run in=http|text|grpc` size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants