fix(recipes): bump Hugging Face Hub helper-job pins to 1.16.4#10986
Conversation
|
👋 Hi MatejKosec! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
WalkthroughThe PR updates Kubernetes job startup scripts across LoRA sync and recipe model-download workflows to install ChangesHugging Face client pin update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This comment has been minimized.
This comment has been minimized.
|
| PR | base behind main | chart carries flag? | deploy-operator |
|---|---|---|---|
| #10986 (this) | current | yes | fail |
| #11034 | 12 behind | yes | fail |
| #11039 | 169 behind | no (predates d8cdf13) | pass |
| #11037 | 169 behind | no (predates d8cdf13) | pass |
| main post-merge | — | yes, but builds fresh <sha>-operator |
pass |
Main's own post-merge deploy-operator passes because its Operator build job runs and deploys a fresh <sha>-operator image — main never exercises the stale floating tag, which is why this doesn't show up on main.
Fix is upstream: republish the main-operator floating tag from current main (so it carries the flag), or stop the PR deploy path from falling back to a stale floating tag when the operator build is skipped. I've re-run deploy-operator in case the tag gets republished; if it fails identically, no change to this PR will make it green. Posting this for visibility so the upstream CI/operator owners can republish the tag. The PR diff itself is review-clean (2× APPROVED, Devin 0 blocking).
|
Update (2026-06-29): re-ran The ephemeral namespace comes up empty on
Neither is caused by this PR's diff (18 YAML pin bumps) or fixable from it. Holding for the CI/operator owners to republish |
Co-Authored-By: Claude <noreply@anthropic.com> (cherry picked from commit 5b090f6)
16d177c to
7c8059f
Compare
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
⚠️ 1 issue in files not directly in the diff
⚠️ Version bump missed one recipe file, leaving it on the old dependency version (recipes/qwen3-vl-32b-fp8/model-cache/model-download.yaml:36)
One model-download recipe still pins the old library version (huggingface_hub==1.11.0 at recipes/qwen3-vl-32b-fp8/model-cache/model-download.yaml:36) while every other file was updated to 1.16.4, so this recipe will install a different, outdated version.
Impact: The Qwen3-VL-32B-FP8 model download job will use an older library version than all other recipes, potentially missing bug fixes or behaving inconsistently.
Incomplete mechanical transformation across YAML files
The PR updates huggingface_hub from 1.11.0 to 1.16.4 in 17 YAML files. However, recipes/qwen3-vl-32b-fp8/model-cache/model-download.yaml:36 was not included in the diff and still contains pip install --no-cache-dir huggingface_hub==1.11.0. Every other pinned occurrence in the repo has been updated to 1.16.4.
Summary
Updates the Hugging Face Hub CLI pin used by Dynamo model-cache and vLLM LoRA helper jobs from
1.11.0to1.16.4.Issue #10857 reports that the Qwen3-32B model-cache job fails after installing
huggingface_hub==1.11.0because thehfCLI import path is missingclick. The issue reporter confirmed thathuggingface_hub==1.16.4installs the needed CLI dependencies and allows the samehf downloadcommand to run.Scope
This change is limited to helper YAML files that install Hugging Face Hub immediately before an
hf downloadcommand. It preserves the existing package spelling in each file:huggingface_hub==1.11.0→huggingface_hub==1.16.4huggingface-hub==1.11.0→huggingface-hub==1.16.4No model IDs, revisions, cache paths, PVCs, image names, resource requests,
awsclipins, HF token wiring, Dockerfiles, runtime code, operator code, Rust code, or Python code are changed.Files changed
The diff contains 18 one-line YAML replacements under:
recipes/*/model-cache/model-download*.yamlexamples/backends/vllm/deploy/lora/**/sync-lora-job.yamlValidation
The factory run validated the generated branch before publication:
pre-commit run --files <18 changed YAML files> --hook-stage manualpassed.huggingface[_-]hub==1.11.0pins remain in the planned recipe/example scope.hf downloadcommand and that the diff consists only of exact1.11.0→1.16.4pin replacements.huggingface_hub==1.16.4and imported bothclickandhuggingface_hub.cli.hf.mainsuccessfully.A full Kubernetes model-cache job was not run because it would require cluster/PVC/HF-token setup and large model downloads. This PR addresses the CLI dependency pin that caused the import failure.
Summary by CodeRabbit
Closes DYN-3335