feat: add GPUDirect support for intel xpu on Dynamo#5852
Conversation
|
👋 Hi Spycsh! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
WalkthroughThe PR introduces a fallback import mechanism for improved vLLM version compatibility and adds a new Bash script for orchestrating a distributed VLLM multi-worker setup with KV routing on XPU devices, using separate decode and prefill workers with GDR configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@examples/backends/vllm/launch/disagg_router_xpu_gdr.sh`:
- Around line 1-6: Remove the leading blank line so the shebang (#!/bin/bash) is
the very first byte of the file, and update the SPDX header year line (the
Copyright comment that currently contains "2025") to include 2026 (e.g.,
"2025-2026") so the copyright check passes; then run shellcheck quickly to
ensure the existing set -e and trap 'echo Cleaning up...; kill 0' EXIT are valid
and adjust quoting/exit handling if shellcheck flags issues.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
8ed5be7 to
438a6dd
Compare
Signed-off-by: Spycsh <sihan.chen@intel.com>
|
Hi @rmccorm4 , could you please help review this PR and merge this? This PR gives a simple example on 2P2D disaggregation on Intel XPU using GPUDirect. Dependencies have been resolved and upstreamed in vllm-project/vllm#35270. Thanks! |
Signed-off-by: Spycsh <sihan.chen@intel.com>
Signed-off-by: Spycsh <sihan.chen@intel.com>
|
Kindly ping @PeaBrane @GuanLuo @tedzhouhk for review:) |
|
/ok to test 7997cf9 |
|
@rmccorm4 thanks, done. |
Signed-off-by: Spycsh <sihan.chen@intel.com>
|
/ok to test e509793 |
Signed-off-by: Spycsh <sihan.chen@intel.com> Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
Overview:
Add validated path of gdr for Intel XPU on Dynamo. Also fix related issues.
Details:
Validate running a vLLM 2P2D disaggregation example in Dynamo on Intel XPU, with GPUDirect KV transfer.
router-mode is set to be kv and smart routing is also validated to work correctly from my end.
Summary by CodeRabbit
Bug Fixes
New Features
✏️ Tip: You can customize this high-level summary in your review settings.