Remove coupled LossContributionsConfig#1158
Open
jpdunc23 wants to merge 5 commits into
Open
Conversation
jpdunc23
commented
May 11, 2026
| @@ -1366,15 +1367,29 @@ def _process_ensemble_output_list( | |||
|
|
|||
|
|
|||
| class CoupledStepperTrainLoss: | |||
Member
Author
There was a problem hiding this comment.
Could move this to loss.py to reduce the length of this file, but not in this PR to avoid hiding the API changes in the diff.
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
LossContributionsConfigand move its config attributes (n_steps,optimize_last_step_only, andweight) toComponentTrainingConfig(asn_steps_optim,optimize_last_step_only, andloss_weight, respectively).Changes:
symbol (e.g.
fme.core.my_function) or script and concise description of changes or added featureCan group multiple related symbols on a single bullet
Tests added
If dependencies changed, "deps only" image rebuilt and "latest_deps_only_image.txt" file updated
Resolves # (delete if none)