Flexible coupling of atmosphere, ice, and ocean components#1179
Open
William-gregory wants to merge 22 commits into
Open
Flexible coupling of atmosphere, ice, and ocean components#1179William-gregory wants to merge 22 commits into
William-gregory wants to merge 22 commits into
Conversation
different options for coupling4 different options for coupling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not intended to be a PR to be merged, but rather a place to show and discuss the best ways to proceed for introducing a sea ice component to
fme.coupled. In this version, I have adapted the codebase to handle the following cases:atmosphere-icecoupling,ice-oceancoupling,atmosphere-oceancoupling, andatmosphere-ice-oceancoupling. The ice-ocean coupling is working in this code. However, as I only have data for ice-ocean coupling, I have not been able to check that coupling with an atmosphere still works.This PR contains a bunch of changes to
fme.coupled,fme.aceandfme.corein order to include a sea ice component. Infme.coupled, the coupling strategy is not super tidy, as it involves a fair amount of code repetition. Specifically, I have changed all instances ofstepper.atmosphereandstepper.oceanto be optionalNone(and same for the newstepper.ice). Then, the code just checks which component isNoneand does the corresponding coupling. E.g.,if stepper.atmosphere is Nonethen the code assumes both ice and ocean are present and that the user is performing ice-ocean coupling.There are also a bunch of config files and other changes unrelated to the coupling which have crept into this branch; you can ignore these.