Bump to torch 2.11#1185
Draft
elynnwu wants to merge 6 commits into
Draft
Conversation
Bumps [torch](https://github.com/pytorch/pytorch) from 2.7.1 to 2.8.0. - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md) - [Commits](pytorch/pytorch@v2.7.1...v2.8.0) --- updated-dependencies: - dependency-name: torch dependency-version: 2.8.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
mcgibbon
approved these changes
May 19, 2026
Contributor
mcgibbon
left a comment
mcgibbon
left a comment
There was a problem hiding this comment.
LGTM. One nit, but perhaps it would be best to consider it in a follow-on PR to get this merged.
|
|
||
| ENV FORCE_CUDA_EXTENSION=1 | ||
| ENV CUDA_HOME=/usr/local/cuda | ||
| ENV TORCH_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0 10.0+PTX" |
Contributor
There was a problem hiding this comment.
nit: Is it possible deduplicate this list against the one in docker/install_torch_harmonics_cuda.sh? Not sure how, but some kind of shared file both reference, if it's possible. Even just a with_cuda_environment.sh <command> script that runs the given command with CUDA_HOME and TORCH_CUDA_ARCH_LIST set.
Contributor
|
GPU tests are failing with a NCCL error, which is somewhat concerning given the nature of the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of why the PR is needed and how it satisfies those requirements, in sentence form.
Changes:
symbol (e.g.
fme.core.my_function) or script and concise description of changes or added featureCan group multiple related symbols on a single bullet
Tests added
If dependencies changed, "deps only" image rebuilt and "latest_deps_only_image.txt" file updated
Resolves # (delete if none)