feat(memory): add CUSTOM strategy type to agentcore-cli (#677)#22
Closed
aidandaly24 wants to merge 2 commits into
Closed
feat(memory): add CUSTOM strategy type to agentcore-cli (#677)#22aidandaly24 wants to merge 2 commits into
aidandaly24 wants to merge 2 commits into
Conversation
Enable self-managed (CUSTOM) memory strategy in the CLI, aligning with the CDK constructs which already support customMemoryStrategy via CloudFormation. Changes: - Add CUSTOM to MemoryStrategyTypeSchema enum and validation - Add CUSTOM description to TUI wizard strategy picker - Update CLI help text, LLM-compacted types, and AGENTS.md - Add documentation for self-managed strategy in docs/ - Update tests: flip rejection tests to acceptance, add new cases - Regenerate asset snapshots Constraint: CDK already maps CUSTOM → customMemoryStrategy in CFN Rejected: New SELF_MANAGED type | cross-layer naming inconsistency with CDK Confidence: high Scope-risk: narrow
Eliminates source-of-truth drift by deriving the valid strategies array and CLI help text from MemoryStrategyTypeSchema.options instead of maintaining hand-written duplicates. Constraint: MemoryStrategyTypeSchema is the single source of truth Confidence: high Scope-risk: narrow
Package Tarballaws-agentcore-0.3.0-preview.8.0.tgz How to installnpm install https://github.com/aidandaly24/agentcore-cli/releases/download/pr-22-tarball/aws-agentcore-0.3.0-preview.8.0.tgz |
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
CUSTOMas a 4th memory strategy type across schema, CLI, TUI, and documentation. This enables users to configure self-managed memory strategies with user-controlled extraction logic, closing the gap between the CDK (which already supportedCUSTOM) and the CLI.Changes:
CUSTOMtoMemoryStrategyTypeSchemaZod enumCUSTOMdescription to TUI strategy selection screenCUSTOMintentionally has no default namespaces inDEFAULT_STRATEGY_NAMESPACES(usesPartial<Record>for type safety)memory.md,commands.md,configuration.md) andAGENTS.mdRelated Issue
Closes aws#677
Documentation PR
N/A — docs updated inline in
docs/directory.Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsAdditional testing:
--strategies CUSTOMproduces{"type":"CUSTOM"}with no namespaces key)posix_spawnpissues)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.