Skip to content

Commit 083134a

Browse files
fix: address Devin Review findings - commit gate fail-open + total_tests count
- check_uncommitted() now validates git status returncode before parsing output - Updated metadata.total_tests from 115 to 116 to reflect F_GRAPHICS_002 addition Co-Authored-By: Tony Ha <aidoruao@gmail.com>
1 parent dc08400 commit 083134a

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

automation/zed_commit_gate.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ def check_uncommitted():
2222
["git", "status", "--porcelain"],
2323
capture_output=True, text=True
2424
)
25+
if result.returncode != 0:
26+
print(f"COMMIT GATE: ERROR - git status failed (exit code {result.returncode})")
27+
print(f"stderr: {result.stderr.strip()}")
28+
sys.exit(2)
2529
return [
2630
line for line in result.stdout.strip().split("\n")
2731
if line.strip()

ontology/falsification_tests.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"description": "Machine-readable falsification test registry. Each entry defines a falsifiable assumption, the strategy for testing it, and mappings to domains, OI-IDs, and case studies. Tests are assigned F-IDs and can be referenced by test files via the @falsification_id tag.",
55
"created": "2026-03-02",
66
"tagging_convention": "Add a comment '# @falsification_id: F_XXX_NNN' at the top of any test that implements or covers a falsification test listed here.",
7-
"total_tests": 115
7+
"total_tests": 116
88
},
99
"falsification_tests": [
1010
{

0 commit comments

Comments
 (0)